From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] sngrep: remove ncurses wchar support
Date: Sat, 15 Jul 2017 23:15:49 +0200 [thread overview]
Message-ID: <20170715231549.46c4bcc5@windsurf> (raw)
In-Reply-To: <20170714153835.3117-1-aduskett@gmail.com>
Hello,
On Fri, 14 Jul 2017 11:38:35 -0400, Adam Duskett wrote:
> sngrep currently doesn't really use wchar support anyways, and when
> checking for wchar support, it's checking the host systems ncurses
> libraries.
>
> Remove support for ncurses wchar until it's used in sngrep, and remove
> the patches used to fix ncurses wchar detection.
>
> Signed-off-by: Adam Duskett <aduskett@gmail.com>
> ---
> ...001-autotools-fix-ncurses-wchar-detection.patch | 158 ---------------------
> ...002-autotools-fix-ncurses-wchar-detection.patch | 45 ------
> package/sngrep/sngrep.mk | 4 -
> 3 files changed, 207 deletions(-)
> delete mode 100644 package/sngrep/0001-autotools-fix-ncurses-wchar-detection.patch
> delete mode 100644 package/sngrep/0002-autotools-fix-ncurses-wchar-detection.patch
I found out it was possible to fix the build issues by passing the
appropriate
SNGREP_NCURSESxyz_CONFIG_SCRIPT=$(STAGING_DIR)/usr/bin/ncursesxyz-config,
but since you say wchar isn't really used by sngrep anyway, I don't
think it's worth adding even more complexity, and I'm happy to see
patches being removed.
Therefore: applied. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2017-07-15 21:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 15:38 [Buildroot] [PATCH 1/1] sngrep: remove ncurses wchar support Adam Duskett
2017-07-15 21:15 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170715231549.46c4bcc5@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox