From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Build failure with 2017.05.1
Date: Wed, 19 Jul 2017 21:09:32 +0200 [thread overview]
Message-ID: <20170719210932.59467c37@windsurf> (raw)
In-Reply-To: <1662234505.617742.1500487581506.JavaMail.zimbra@datacom.ind.br>
Hello,
On Wed, 19 Jul 2017 15:06:21 -0300 (BRT), Carlos Santos wrote:
> I got this error while building protobuf with Buildroot 2017.05.1:
>
> >>> host-protobuf 3.2.0 Downloading
> [...]
> --2017-07-18 17:30:20-- https://github.com/google/protobuf/commit/416f90939d4de58fe1a4e2489120010313183291.patch
> [...]
> ERROR: 416f90939d4de58fe1a4e2489120010313183291.patch has wrong sha256 hash:
> ERROR: expected: da80c39838515913633f4cbd875fdd4ad711be95c83a50ff5096b9f1254033b3
> ERROR: got : 61e5b65b65e10f3ae7549b3a38eb30162ef298e387b1779d997ddf3633d63700
> ERROR: Incomplete download, or man-in-the-middle (MITM) attack
>
> Looks like the "patches downloaded from Github are not stable"
> issue already fixed by Thomas Petazzoni in several recipes.
>
> I solved the problem by means of a local change that brings
> the patch in the tree.
>
> Should I submit a patch specific for the 2017.05.x branch or it
> would be preferable to cherry-pick the commits that bump protobuf
> to v3.3.0 from master to 2017.05.x?
We definitely don't want the bump to v3.3.0 in the maintenance branch,
unless there are security fixes associated.
However, I think we want to do in 2017.02.x and 2017.05.x what we did
in master: remove all Github patch downloads, and put the patches in
the tree instead. For most of the packages, I believe the commits can
be cherry-picked from master. A few packages will need specific
adjustments though.
Peter, do you agree?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-07-19 19:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 18:06 [Buildroot] Build failure with 2017.05.1 Carlos Santos
2017-07-19 19:09 ` Thomas Petazzoni [this message]
2017-07-19 19:38 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719210932.59467c37@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox