From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 3/3] package/nodejs: use shared libuv
Date: Wed, 19 Jul 2017 22:46:00 +0200 [thread overview]
Message-ID: <20170719224600.6edd899e@windsurf> (raw)
In-Reply-To: <1500378343-22978-3-git-send-email-martin@barkynet.com>
Hello,
On Tue, 18 Jul 2017 12:45:43 +0100, Martin Bark wrote:
> diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
> index f02b9a7..d3cb006 100644
> --- a/package/nodejs/Config.in
> +++ b/package/nodejs/Config.in
> @@ -5,15 +5,17 @@ config BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
> default y if BR2_mipsel && !BR2_MIPS_SOFT_FLOAT
> default y if BR2_aarch64 || BR2_i386 || BR2_x86_64
>
> -comment "nodejs needs a toolchain w/ C++, dynamic library, threads, gcc >= 4.8, wchar"
> +comment "nodejs needs a toolchain w/ C++, dynamic library, NPTL, gcc >= 4.8, wchar"
> depends on BR2_USE_MMU
> depends on BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
> - depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS || \
> + depends on BR2_TOOLCHAIN_HAS_SYNC_4
> + depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
> !BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || !BR2_USE_WCHAR
>
> config BR2_PACKAGE_NODEJS
> bool "nodejs"
> - depends on BR2_TOOLCHAIN_HAS_THREADS
> + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # libuv
> + depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libuv
BR2_TOOLCHAIN_HAS_SYNC_4 really is an architecture dependency (we don't
show a Config.in comment for it), so I've moved it under
BR2_PACKAGE_NODEJS_ARCH_SUPPORTS, so it doesn't have to be duplicated.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-07-19 20:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 11:45 [Buildroot] [PATCH v2 1/3] package/nodejs: use shared c-ares Martin Bark
2017-07-18 11:45 ` [Buildroot] [PATCH v2 2/3] package/nodejs: use shared libhttpparser Martin Bark
2017-07-18 11:45 ` [Buildroot] [PATCH v2 3/3] package/nodejs: use shared libuv Martin Bark
2017-07-19 20:46 ` Thomas Petazzoni [this message]
2017-07-19 20:45 ` [Buildroot] [PATCH v2 1/3] package/nodejs: use shared c-ares Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719224600.6edd899e@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox