From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 4/4] autobuild-run: adapt to genrandconfig with toolchains-csv option
Date: Fri, 21 Jul 2017 03:06:21 +0200 [thread overview]
Message-ID: <20170721010621.4877-4-arnout@mind.be> (raw)
In-Reply-To: <20170721010621.4877-1-arnout@mind.be>
The --toolchains-url option has been removed from genrandconfig, it has
been replaced with --toolchains-csv.
We don't actually need to pass this option if not set, so that the
in-tree default will be used. This makes sure that the autobuild-run
doesn't need to be updated if we change the location of the CSV file.
The -i option has been removed from genrandconfig, it has been replaced
with an explicit -o OUTPUTDIR and -b BUILDROOTDIR.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
scripts/autobuild-run | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index 0f9d046..f1dade4 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -67,7 +67,7 @@ defaults = {
'--nice': 0,
'--pid-file': '/tmp/buildroot-autobuild.pid',
'--http-url': 'http://autobuild.buildroot.org/submit/',
- '--toolchains-url': 'http://autobuild.buildroot.org/toolchains/configs/toolchain-configs.csv',
+ '--toolchains-csv': 'support/config-fragments/autobuild/toolchain-configs.csv',
}
doc = """autobuild-run - run Buildroot autobuilder
@@ -102,7 +102,7 @@ Options:
-c, --config CONFIG path to configuration file
Not set by default.
-d, --debug Send log output to stdout instead of log file
- --toolchains-url URL URL of toolchain configuration file
+ --toolchains-csv CSVFILE Toolchain configuration file
Format of the configuration file:
@@ -314,10 +314,17 @@ def gen_config(**kwargs):
devnull = log
else:
devnull = open(os.devnull, "w")
- ret = subprocess.call([os.path.join(srcdir, "utils/genrandconfig"),
- "-o", outputdir, "-b", srcdir,
- "--toolchains-url", kwargs['toolchains_url']],
- stdout=devnull, stderr=log)
+
+ args = [os.path.join(srcdir, "utils/genrandconfig"),
+ "-o", outputdir, "-b", srcdir]
+
+ toolchains_csv = kwargs['toolchains_csv']
+ if toolchains_csv:
+ if not os.path.isabs(toolchains_csv):
+ toolchains_csv = os.path.join(srcdir, toolchains_csv)
+ args.extend(["--toolchains-csv", toolchains_csv])
+
+ ret = subprocess.call(args, stdout=devnull, stderr=log)
return ret
def do_build(**kwargs):
@@ -666,7 +673,7 @@ def main():
submitter = args['--submitter'],
make_opts = (args['--make-opts'] or ''),
nice = (args['--nice'] or 0),
- toolchains_url = args['--toolchains-url'],
+ toolchains_csv = args['--toolchains-csv'],
upload = upload,
buildpid = buildpid,
debug = args['--debug']
--
2.13.2
next prev parent reply other threads:[~2017-07-21 1:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 1:05 [Buildroot] [PATCH v7 00/23] Move toolchain configs and autobuild logic in-tree Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 01/23] utils/genrandconfig: new script Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 02/23] genrandconfig: use subprocess.check_output instead of Popen Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 03/23] genrandconfig: fix (some) pep8 warnings Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 04/23] genrandconfig: replace kwargs with explicit arguments Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 05/23] genrandconfig: move instantiation of SystemInfo down Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 06/23] genrandconfig: verbose output and use stderr Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 07/23] genrandconfig: calculate outputdir in __main__ Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 08/23] genrandconfig: calculate buildrootdir " Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 09/23] genrandconfig: pass outputdir and buildrootdir as arguments Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 10/23] genrandconfig: calculate configfile only once Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 11/23] genrandconfig: fix the case when outputdir is 'output' Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 12/23] support/test-pkg: move minimal.config into a separate file Arnout Vandecappelle
2017-07-21 7:01 ` Thomas Petazzoni
2017-07-21 1:05 ` [Buildroot] [PATCH v7 13/23] minimal.config: add BR2_COMPILER_PARANOID_UNSAFE_PATH=y Arnout Vandecappelle
2017-07-21 7:01 ` Thomas Petazzoni
2017-07-21 1:05 ` [Buildroot] [PATCH v7 14/23] minimal.config: add BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y Arnout Vandecappelle
2017-07-21 7:01 ` Thomas Petazzoni
2017-07-21 1:05 ` [Buildroot] [PATCH v7 15/23] genrandconfig: use minimal.config Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 16/23] support: add autobuild toolchain config fragments Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 17/23] test-pkg: get configs from in-tree toolchain-configs.csv Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 18/23] support/test-pkg: add option to use an alternate toolchains CSV file Arnout Vandecappelle
2017-07-25 21:05 ` Thomas Petazzoni
2017-07-21 1:05 ` [Buildroot] [PATCH v7 19/23] genrandconfig: get configs from in-tree toolchain-configs.csv Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 20/23] toolchain-configs.csv: remove unused libc column Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 21/23] Makefile: refactor *config targets Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 22/23] Makefile: add alldefconfig target Arnout Vandecappelle
2017-07-21 1:05 ` [Buildroot] [PATCH v7 23/23] test-pkg: use merge_config.sh to merge the fragments Arnout Vandecappelle
2017-07-21 1:06 ` [Buildroot] [PATCH v3 1/4] autobuild-run: use in-tree genrandconfig script (initial version) Arnout Vandecappelle
2017-07-21 1:06 ` [Buildroot] [PATCH v3 2/4] autobuild-run: adapt to genrandconfig without log_write Arnout Vandecappelle
2017-07-21 1:06 ` [Buildroot] [PATCH v3 3/4] autobuild-run: adapt to genrandconfig with outputdir and buildrootdir options Arnout Vandecappelle
2017-07-21 1:06 ` Arnout Vandecappelle [this message]
2017-07-25 21:24 ` [Buildroot] [PATCH v3 1/4] autobuild-run: use in-tree genrandconfig script (initial version) Thomas Petazzoni
2017-07-25 21:10 ` [Buildroot] [PATCH v7 00/23] Move toolchain configs and autobuild logic in-tree Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170721010621.4877-4-arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox