From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sat, 22 Jul 2017 15:25:11 +0200 Subject: [Buildroot] [PATCH 1/1] brcm-patchram-plus: new package In-Reply-To: <20170721144520.14683-1-alexey.roslyakov@gmail.com> References: <20170721144520.14683-1-alexey.roslyakov@gmail.com> Message-ID: <20170722152511.4ffc8dd3@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Fri, 21 Jul 2017 21:45:20 +0700, Alexey Roslyakov wrote: > Many of Broadcom BCM43XX WiFi/Bluetooth combo chips have pretty tricky initialization. > Broadcom patchram utility has been released to address the issue. > > Signed-off-by: Alexey Roslyakov Thanks for this contribution! See a few comments below. > diff --git a/DEVELOPERS b/DEVELOPERS > index 7b7c5ab4e6..45466591da 100644 > --- a/DEVELOPERS > +++ b/DEVELOPERS > @@ -73,6 +73,9 @@ N: Alexandre Esse > F: package/kvazaar/ > F: package/v4l2loopback/ > > +N: Alexey Roslyakov > +F: package/brcm-patchram-plus Please end the package path with a /, like all other entries in the DEVELOPERS file. > diff --git a/package/brcm-patchram-plus/Config.in b/package/brcm-patchram-plus/Config.in > new file mode 100644 > index 0000000000..f7df21d2b2 > --- /dev/null > +++ b/package/brcm-patchram-plus/Config.in > @@ -0,0 +1,6 @@ > +config BR2_PACKAGE_BRCM_PATCHRAM_PLUS > + bool "brcm-patchram-plus" > + help > + Utility's to configure and test Broadcom Bluetooth chips on Linux. > + > + https://code.google.com/archive/p/broadcom-bluetooth/ Indentation for the help text is one tab + two spaces. I would recommend you to run utils/check-package on your new package to catch such coding style issues. > +BRCM_PATCHRAM_PLUS_VERSION = 0.1.1 > +BRCM_PATCHRAM_PLUS_SOURCE = brcm-patchram-plus_$(BRCM_PATCHRAM_PLUS_VERSION).tar.gz > +BRCM_PATCHRAM_PLUS_SITE = https://launchpad.net/ubuntu/+archive/primary/+files Perhaps using the git repository at https://chromium.googlesource.com/chromiumos/third_party/broadcom would be a more "official" upstream ? > +define BRCM_PATCHRAM_PLUS_BUILD_CMDS > + $(TARGET_CC) -o $(@D)/brcm_patchram_plus $(@D)/brcm_patchram_plus.c > +endef > + > +define BRCM_PATCHRAM_PLUS_INSTALL_TARGET_CMDS > + $(INSTALL) -D -m 0755 $(@D)/brcm_patchram_plus $(TARGET_DIR)/usr/bin/brcm_patchram_plus > +endef What about using the Makefile that comes inside the package ? At least in the Git repository I pointed to, there is a Makefile that seems suitable. Thanks! Thoma -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com