Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/4] testing/infra/builder: dump config to log
Date: Sun, 23 Jul 2017 11:14:42 +0200	[thread overview]
Message-ID: <20170723091441.GB2917@scaer> (raw)
In-Reply-To: <20170723042019.10323-2-ricardo.martincoski@gmail.com>

Ricardo, All,

On 2017-07-23 01:20 -0300, Ricardo Martincoski spake thusly:
> The config is composed on-the-fly by test infra + tests.
> 
> Dump it to the logfile before running 'make olddefconfig' so it can
> easily analysed when debugging.
> 
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> ---
>  support/testing/infra/builder.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/support/testing/infra/builder.py b/support/testing/infra/builder.py
> index a475bb0a30..dc128cdd8a 100644
> --- a/support/testing/infra/builder.py
> +++ b/support/testing/infra/builder.py
> @@ -17,6 +17,9 @@ class Builder(object):
>          config_file = os.path.join(self.builddir, ".config")
>          with open(config_file, "w+") as cf:
>              cf.write(self.config)
> +        # dump the config to the logfile for easy debugging
> +        self.logfile.write("> config:\n" + self.config)
> +        self.logfile.flush()

Although the variable is named 'comfig', it is in fact a defconfig.

Also, it is easy to miss exactly where the end of the config is, so
maybe:

  - prefix all lines with 'config: ',
or
  - add 'start config' and 'end config'.

Otherwise;

Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

>  
>          cmd = ["make",
>                 "O={}".format(self.builddir),
> -- 
> 2.13.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2017-07-23  9:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-23  4:20 [Buildroot] [PATCH 1/4] DEVELOPERS: add Ricardo Martincoski for support/testing Ricardo Martincoski
2017-07-23  4:20 ` [Buildroot] [PATCH 2/4] testing/infra/builder: dump config to log Ricardo Martincoski
2017-07-23  9:14   ` Yann E. MORIN [this message]
2017-07-23 18:44     ` Ricardo Martincoski
2017-07-23 21:44   ` [Buildroot] [PATCH v2 1/3] testing/infra/builder: dump defconfig " Ricardo Martincoski
2017-07-23 21:44     ` [Buildroot] [PATCH v2 2/3] support/testing: fix run-tests -j Ricardo Martincoski
2017-07-23 21:44     ` [Buildroot] [PATCH v2 3/3] testing/infra/basetest: move jlevel logic to constructor Ricardo Martincoski
2017-07-24 15:55     ` [Buildroot] [PATCH v2 1/3] testing/infra/builder: dump defconfig to log Thomas Petazzoni
2017-07-23  4:20 ` [Buildroot] [PATCH 3/4] support/testing: fix run-tests -j Ricardo Martincoski
2017-07-23  9:01   ` Yann E. MORIN
2017-07-23  4:20 ` [Buildroot] [PATCH 4/4] testing/infra/basetest: move jlevel logic to constructor Ricardo Martincoski
2017-07-23  9:20   ` Yann E. MORIN
2017-07-25 20:20 ` [Buildroot] [PATCH 1/4] DEVELOPERS: add Ricardo Martincoski for support/testing Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170723091441.GB2917@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox