From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Sun, 23 Jul 2017 11:45:28 +0200 Subject: [Buildroot] [PATCH 11/20] package/skeleton: split out into skeleton-custom In-Reply-To: References: <6929bbc3-48c2-4041-a1bb-2e3602c92e4a@mind.be> Message-ID: <20170723094528.GA26998@scaer> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 2017-07-23 00:38 +0200, Arnout Vandecappelle spake thusly: > On second thought... > > On 23-07-17 00:31, Arnout Vandecappelle wrote: > >> +define SKELETON_CUSTOM_INSTALL_STAGING_CMDS > >> + $(call SYSTEM_RSYNC,$(SKELETON_CUSTOM_PATH),$(STAGING_DIR)) > >> + $(call SYSTEM_LIB_SYMLINK,$(STAGING_DIR)) > > In skeleton-common, we also have: > > $(INSTALL) -d -m 0755 $(STAGING_DIR)/usr/include > > Shouldn't we do that here as well? In fact, I argue that we should not have this mkdir at all: https://patchwork.ozlabs.org/patch/710672/ I propagated it here because the patch is just about moving stuff, not cleaning up. Regards, Yann E. MORIN. > Regards, > Arnout > > >> +endef > > -- > Arnout Vandecappelle arnout at mind be > Senior Embedded Software Architect +32-16-286500 > Essensium/Mind http://www.mind.be > G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven > LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle > GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'