Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] grep: remove musl build workaround
Date: Mon, 24 Jul 2017 18:27:16 +0200	[thread overview]
Message-ID: <20170724182716.6b515984@windsurf.lan> (raw)
In-Reply-To: <f9b18f3f76137e6c4de2d0a72154ec79223019d9.1500868794.git.baruch@tkos.co.il>

Hello,

On Mon, 24 Jul 2017 06:59:54 +0300, Baruch Siach wrote:
> Commit de903755d79e (grep: fix build failure for musl) added
> --with-included-regex to configure options in musl builds. The commit log
> mentions build failure because grep configure doesn't detect the missing libc
> regex support. Unfortunately, the commit log adds no details on said build
> failure, or any autobuilder reference. The autobuilder didn't record
> any grep build failure for version 2.20 that was current at the time.
> 
> Build with musl succeeds nowadays, so remove the workaround.

I tried to research a bit for this one, but couldn't find anything.
Even grep 2.20 had m4/regex.m4 that was checking if there is a working
regex implementation in the C library, and if not falls back on using
the gnulib provided version. And this AC_RUN_IFELSE() test properly
defaults to assuming that the libc doesn't provide a regex
implementation when cross-compiling (because AC_RUN_IFELSE tests can't
be executed when cross compiling).

So I'm a bit puzzled why this was needed in the first place. I've
applied, and we'll see if anyone complains.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-07-24 16:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24  3:59 [Buildroot] [PATCH 1/3] grep: bump to version 3.1 Baruch Siach
2017-07-24  3:59 ` [Buildroot] [PATCH 2/3] grep: standardise pcre optional dependency Baruch Siach
2017-07-24  3:59 ` [Buildroot] [PATCH 3/3] grep: remove musl build workaround Baruch Siach
2017-07-24 16:27   ` Thomas Petazzoni [this message]
2017-07-24 16:25 ` [Buildroot] [PATCH 1/3] grep: bump to version 3.1 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170724182716.6b515984@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox