From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/9] fix help text wrapping for configs e
Date: Mon, 31 Jul 2017 19:24:24 +0200 [thread overview]
Message-ID: <20170731192424.74fe19a7@windsurf.home> (raw)
In-Reply-To: <20170731191403.64ed5fae@windsurf.home>
Hello,
On Mon, 31 Jul 2017 19:14:03 +0200, Thomas Petazzoni wrote:
> I've applied the series but:
>
> * There was a leftover PATCH 4/4 in the middle of the series. Please
> try to be careful when sending series.
>
> * The subjects were not really formatted properly. They did not comply
> with the principle of "<package>: <description>". I fixed this up.
>
> * It's generally quite annoying to get such patches now, when we're
> about to close for -rc1. Do you really want to spend the
> reviewer/maintainer time on reviewing/applying such patches, or
> focus on more important things ? I know we need at some point to fix
> all those warnings, but it's always annoying to receive such massive
> patches :-/
And in addition, you did not even test your patches by running "make
menuconfig". They broke menuconfig:
package/libsysfs/Config.in:8: syntax error
package/libsysfs/Config.in:7: unknown option "http"
Makefile:876: recipe for target 'menuconfig' failed
make[1]: *** [menuconfig] Error 1
I already applied and pushed a follow-up fix for this.
But that can only strengthen my dislike for such patches...
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-07-31 17:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 13:53 [Buildroot] [PATCH 1/9] fix help text wrapping for configs e Adam Duskett
2017-07-31 13:53 ` [Buildroot] [PATCH 2/9] fix help text wrapping for configs f Adam Duskett
2017-07-31 13:53 ` [Buildroot] [PATCH 3/9] fix help text wrapping for configs g Adam Duskett
2017-07-31 13:53 ` [Buildroot] [PATCH 4/9] fix help text wrapping for configs h Adam Duskett
2017-07-31 13:53 ` [Buildroot] [PATCH 4/4] fix help text wrapping for configs i Adam Duskett
2017-07-31 13:53 ` [Buildroot] [PATCH 5/9] " Adam Duskett
2017-07-31 13:53 ` [Buildroot] [PATCH 6/9] fix help text wrapping for configs j Adam Duskett
2017-07-31 13:53 ` [Buildroot] [PATCH 7/9] fix help text wrapping for configs k Adam Duskett
2017-07-31 13:53 ` [Buildroot] [PATCH 8/9] fix help text wrapping for configs l Adam Duskett
2017-07-31 13:53 ` [Buildroot] [PATCH 9/9] fix help text wrapping for configs lib Adam Duskett
2017-07-31 17:14 ` [Buildroot] [PATCH 1/9] fix help text wrapping for configs e Thomas Petazzoni
2017-07-31 17:24 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731192424.74fe19a7@windsurf.home \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox