Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package: libglib2: explicitly specify host's PYTHON to be used
Date: Mon, 31 Jul 2017 21:37:27 +0200	[thread overview]
Message-ID: <20170731213727.01c210fb@windsurf.home> (raw)
In-Reply-To: <20170717221308.16711-1-andrew.smirnov@gmail.com>

Hello,

On Mon, 17 Jul 2017 15:13:08 -0700, Andrey Smirnov wrote:

> +#
> +# We explicitly specify --with-python to point to host's python here
> +# and in LIBGLIB2_CONF_OPTS to make sure that ./configure does not
> +# pick up python from ${HOST_DIR} thus creating a dependency that
> +# would have to be specified in _DEPENDENCIES
> +#
>  HOST_LIBGLIB2_CONF_OPTS = \
>  	--disable-coverage \
>  	--disable-dtrace \
> @@ -98,7 +104,8 @@ HOST_LIBGLIB2_CONF_OPTS = \
>  	--disable-selinux \
>  	--disable-systemtap \
>  	--disable-xattr \
> -	--with-pcre=system
> +	--with-pcre=system \
> +	--with-python=$$(which python)
>  
>  LIBGLIB2_DEPENDENCIES = \
>  	host-pkgconf host-libglib2 host-gettext \
> @@ -114,6 +121,7 @@ HOST_LIBGLIB2_DEPENDENCIES = \
>  
>  LIBGLIB2_CONF_OPTS = \
>  	--with-pcre=system
> +	--with-python=$$(which python)

What is Python being used for in the build process of glib2 ? I'm
concerned by the fact that we're simply passing the path to the host
Python interpreter, even though we're cross-compiling.

It might be correct, if Python is just used to generate some code on
the build machine, but it'd be good to understand.

Also, using `which python` is preferred over $$(which python).

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-07-31 19:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17 22:13 [Buildroot] [PATCH] package: libglib2: explicitly specify host's PYTHON to be used Andrey Smirnov
2017-07-31 19:37 ` Thomas Petazzoni [this message]
2017-07-31 20:04   ` Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170731213727.01c210fb@windsurf.home \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox