Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] swupdate: support for Lua 5.1 is broken
Date: Tue, 1 Aug 2017 19:10:32 +0200	[thread overview]
Message-ID: <20170801191032.6c2ca207@windsurf.home> (raw)
In-Reply-To: <20170731211800.5888-2-joerg.krause@embedded.rocks>

Hello,

On Mon, 31 Jul 2017 23:18:00 +0200, J?rg Krause wrote:
> Before commit 87b6ac1478821351c92f7ca1c3154550e4713b28 support for Lua
> was always disabled by the default config file:
> 
> ```
> CONFIG_LUA is not set
> ```
> 
> The commit removed this setting and Lua support is now enabled if a Lua
> interpreter is enabled. As the swupdate build system uses pkg-config to check
> for the lua library by default (LUAPKG="lua") this throws a lot of
> undefined referenced in case LuaJIT is uses as Lua interpreter, e.g.:
> 
> ```
> corelib/lib.a(lua_interface.o): In function `l_info':
> lua_interface.c:(.text.l_info+0x14): undefined reference to `luaL_checklstring'
> ```
> 
> However, since version 2017.07 support for Lua 5.1 is broken in swupdate. Therefore,
> remove support for Lua 5.1 and LuaJIT in the swupdate package for now
> until upstream might fix this issue.

Isn't it better to revert the bump to 2017.07 instead of removing
functionality that people could be relying on ?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-08-01 17:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-31 21:17 [Buildroot] [PATCH 1/2] lua: fix pkg-config file Jörg Krause
2017-07-31 21:18 ` [Buildroot] [PATCH 2/2] swupdate: support for Lua 5.1 is broken Jörg Krause
2017-08-01 17:10   ` Thomas Petazzoni [this message]
2017-08-02  6:42     ` Jörg Krause
2017-08-02  7:46       ` Jörg Krause
2017-08-10 12:51   ` Arnout Vandecappelle
2017-08-01 17:08 ` [Buildroot] [PATCH 1/2] lua: fix pkg-config file Thomas Petazzoni
2017-08-02  8:04   ` Jörg Krause
2017-09-05 21:52 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170801191032.6c2ca207@windsurf.home \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox