From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-cmake.mk: set pkg-config env. vars. in the host configure environment
Date: Sat, 5 Aug 2017 15:42:33 +0200 [thread overview]
Message-ID: <20170805154233.3df3e56f@windsurf> (raw)
In-Reply-To: <20170805130605.25877-1-s.martin49@gmail.com>
Hello,
On Sat, 5 Aug 2017 15:06:05 +0200, Samuel Martin wrote:
> Cmake may run pkg-config to find the dependencies when configuring a
> package. Because of the value of PATH, and it will use the Buildroot's
> pkg-config wrapper, which, by default, is configured (via some
> environment variables) to find the target dependencies.
>
> So, this change makes sure the pkg-config environment variables are
> properly set for finding host dependencies when configuring a
> host-package.
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Is this fixing a particular autobuild failure ?
Is this fixing a specific bug ?
I do remember someone reporting CMake related issues when building host
packages. Perhaps it was an e-mail. In such a case, there should be a
reference to this e-mail, or bug, or autobuild failure.
Currently, it's not clear whether your patch is fixing an actual
problem (and should be applied to master) or is just nice to have
(should be applied to next).
Of course, I do know that this patch is important and should be applied
to master, but it would be good to have a clearer commit log from that
respect.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-08-05 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-05 13:06 [Buildroot] [PATCH] pkg-cmake.mk: set pkg-config env. vars. in the host configure environment Samuel Martin
2017-08-05 13:42 ` Thomas Petazzoni [this message]
2017-08-05 14:00 ` Samuel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170805154233.3df3e56f@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox