Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] fs/squashfs: honour the number of parallel jobs
Date: Sun, 6 Aug 2017 17:40:56 +0200	[thread overview]
Message-ID: <20170806154056.GA2921@scaer> (raw)
In-Reply-To: <20170803092556.752dfa19@windsurf.home>

Thomas, All,

On 2017-08-03 09:25 +0200, Thomas Petazzoni spake thusly:
> On Wed,  2 Aug 2017 23:22:39 +0200, Yann E. MORIN wrote:
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Clayton Shotwell <clayton.shotwell@rockwellcollins.com>
> 
> This would benefit from an extended commit log. Why do we do this? Is
> this fixing something? Is this reducing the duration of mksquashfs
> because it leverages multiple cores when doing the compression? In the
> latter case, a few numbers would be nice to have.

By default, mksquashfs uses all the CPUs available (e.g. like us with
BR2_JLEVEL=0).

However, a user may well set BR2_JLEVEL to a specific value, to
voluntarily limit the number of CPUs to use (e.g. like us on the
autobuilders).

So, this patch just propagates that BR2_JLEVEL setting to mksquashfs,
to use the same number of jobs as the rest of the build process.

So, there is not speed improvement to expect, quite the opposite in
fact. And this is why this patch can be seen as a mitigation (but not a
fix) for #10141, as it allows to reduce the parallelism on systems with
a huge number of CPUs, which is where #10141 occurs.

I'll add a bit more explanations to this patch and respin...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2017-08-06 15:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-02 21:22 [Buildroot] [PATCH] fs/squashfs: honour the number of parallel jobs Yann E. MORIN
2017-08-03  7:25 ` Thomas Petazzoni
2017-08-06 15:40   ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170806154056.GA2921@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox