From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/monolite: bump to version 1050001000
Date: Fri, 11 Aug 2017 20:31:34 +0200 [thread overview]
Message-ID: <20170811203134.4bcad015@windsurf> (raw)
In-Reply-To: <CA+TH9V=Bzj42mksn4cyGzupuDhGRoBG1HGFgKrsGX4pSL5J15Q@mail.gmail.com>
Hello,
On Fri, 11 Aug 2017 17:07:18 +0200, Angelo Compagnucci wrote:
> >> Sorry for the noise, but this is not how the things worked in the
> >> past. I was suggested several times in the past to send a patch for
> >> each modification/package.
> >
> > Yes, but only if they indeed work separately. Don't worry, I'll squash while
> > applying.
>
> I searched the history for the mono package just to be sure and such a
> way of squashing commits for separate packages was never been done.
> I'm a bit puzzled ...
Yes, I used to apply them separately. Theoretically, if the bumps are
really both needed for the whole thing to work, Arnout is right that
both bumps should be done in the same patch.
I simply don't apply an absolutely strict rule of "everything should be
bisectable" in Buildroot, so I'm a bit more relaxed than Arnout on
this. I'm not saying Arnout isn't right, just that it wasn't something
that I thought was important enough.
> Right now I'm working updating sysdig and it requires som bumps to
> other packages, should I send a squashed patch?!
No, because the patch series is bisectable: if we apply only PATCH 1/3,
it works. If we apply patches 1/3 and 2/3, it works. And if we apply
1/3, 2/3 and 3/3, it works.
The question is not whether patches are independent, but whether the
patch series is bisectable. I.e what happens if you apply only M
patches on the total of N patches in the series.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-08-11 18:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 8:14 [Buildroot] [PATCH 1/2] package/monolite: bump to version 1050001000 Angelo Compagnucci
2017-08-11 8:14 ` [Buildroot] [PATCH 2/2] package/mono: bump to version 5.0.1.1 Angelo Compagnucci
2017-08-11 10:00 ` Arnout Vandecappelle
2017-08-11 10:57 ` Angelo Compagnucci
2017-08-11 13:41 ` Arnout Vandecappelle
2017-08-11 9:56 ` [Buildroot] [PATCH 1/2] package/monolite: bump to version 1050001000 Arnout Vandecappelle
2017-08-11 10:40 ` Angelo Compagnucci
2017-08-11 13:38 ` Arnout Vandecappelle
2017-08-11 15:07 ` Angelo Compagnucci
2017-08-11 18:31 ` Thomas Petazzoni [this message]
2017-08-11 20:35 ` Arnout Vandecappelle
2017-08-11 14:07 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170811203134.4bcad015@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox