From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Sat, 12 Aug 2017 12:01:35 +0200
Subject: [Buildroot] [PATCH 2/2] Revert "alsa-utils: amidi option needs
 seq support in alsa-lib"
In-Reply-To: <20170811212103.24433-2-thomas.petazzoni@free-electrons.com>
References: <20170811212103.24433-1-thomas.petazzoni@free-electrons.com>
 <20170811212103.24433-2-thomas.petazzoni@free-electrons.com>
Message-ID: <20170812100135.GC3021@scaer>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Thomas, All,

On 2017-08-11 23:21 +0200, Thomas Petazzoni spake thusly:
> This reverts commit c69088b8c35177cecdd0f1f385c13f5b2c509f1d, which is
> no longer needed now that alsa-lib has been fixed properly.
> 
> Indeed, this commit was made because alsa-utils failed to build with:
> 
> /home/buildroot/build/instance-0/output/host/usr/xtensa-buildroot-linux-uclibc/sysroot/usr/lib/libasound.a(pcm_dmix.o): In function `snd_pcm_dmix_htimestamp':
> pcm_dmix.c:(.text+0x5c0): warning:
> /home/buildroot/build/instance-0/output/host/usr/xtensa-buildroot-linux-uclibc/sysroot/usr/lib/libasound.a(rawmidi_symbols.o):(.data.rel+0x4): undefined reference to `_snd_module_rawmidi_virt'
> collect2: error: ld returned 1 exit status
> 
> Which is exactly the problem that we fixed in alsa-lib by making sure
> that rawmidi_symbols.c doesn't reference symbols from rawmidi_virt.c
> when SEQ support is not enabled.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/alsa-utils/Config.in | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/alsa-utils/Config.in b/package/alsa-utils/Config.in
> index d3fd18d..1a48fc0 100644
> --- a/package/alsa-utils/Config.in
> +++ b/package/alsa-utils/Config.in
> @@ -49,7 +49,6 @@ config BR2_PACKAGE_ALSA_UTILS_ALSATPLG
>  config BR2_PACKAGE_ALSA_UTILS_AMIDI
>  	bool "amidi"
>  	select BR2_PACKAGE_ALSA_LIB_RAWMIDI
> -	select BR2_PACKAGE_ALSA_LIB_SEQ
>  
>  config BR2_PACKAGE_ALSA_UTILS_AMIXER
>  	bool "amixer"
> -- 
> 2.9.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'