From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 14 Aug 2017 22:02:35 +0200 Subject: [Buildroot] [PATCH 1/3] whois: fix build with NLS disabled In-Reply-To: <37040459db3e6ca01e2dc8236cf57a993f1831ed.1502649259.git.baruch@tkos.co.il> References: <37040459db3e6ca01e2dc8236cf57a993f1831ed.1502649259.git.baruch@tkos.co.il> Message-ID: <20170814220235.6e869241@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Sun, 13 Aug 2017 21:34:17 +0300, Baruch Siach wrote: > whois build uses the xgettext utility to build translation files. > This utility may not be available when NLS is disabled. Omit the pos and > install-pos Makefile targets from the default and the install targets > when NLS is disabled, respectively. > > Fixes: > http://autobuild.buildroot.net/results/862/862d8165a59711c970c65d90009a527315a1a6b4/ > http://autobuild.buildroot.net/results/b62/b62ec9d6f350e409731d47ffb585344c516944e8/ > http://autobuild.buildroot.net/results/be2/be28d06ae004a46c87133d6f07709c6f909288d8/ > > Cc: Gustavo Zacarias > Signed-off-by: Baruch Siach Since there is an active upstream at https://github.com/rfc1036/whois, what about doing something upstreamable, such as introducing an HAVE_NLS variable, which the Makefile uses to determine if PO files should be built or not? The Makefile already supports HAVE_LIBIDN, HAVE_ICONV, HAVE_XCRYPT, etc. so introducing HAVE_NLS should fit quite well into this, and it really is a simple patch to do. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com