From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 15 Aug 2017 14:07:39 +0200 Subject: [Buildroot] [PATCH 2/3] whois: use github repo as home page In-Reply-To: <20170815112018.rg7udjb7zlfps4ue@sapphire.tkos.co.il> References: <37040459db3e6ca01e2dc8236cf57a993f1831ed.1502649259.git.baruch@tkos.co.il> <20170814220354.3665d3eb@windsurf> <20170815041434.tlygmw6w4skyih6k@sapphire.tkos.co.il> <20170815125621.4d78c480@windsurf> <20170815112018.rg7udjb7zlfps4ue@sapphire.tkos.co.il> Message-ID: <20170815140739.3370030e@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Tue, 15 Aug 2017 14:20:18 +0300, Baruch Siach wrote: > On Tue, Aug 15, 2017 at 12:56:21PM +0200, Thomas Petazzoni wrote: > > On Tue, 15 Aug 2017 12:10:17 +0200, Arnout Vandecappelle wrote: > > > > > > But we generally prefer upstream provided tarballs, aren't we? Moreover, in > > > > this case the Debian repo provides a smaller .tar.xz, and an upstream computed > > > > SHA256 in the .dsc file. You don't get that from github. > > > > > > On Sunday, I was going to ask the same question, and came to the same > > > conclusion about the tar.xz and the sha256. Unfortunately, I don't remember why > > > I didn't just apply it then and there... > > > > I definitely don't agree here. We should use upstream when it exists, > > even if it provides things that are less "convenient" than Debian. > > > > Otherwise, we're going to convert a *lot* of packages to use tarballs > > from Debian rather than from upstream. > > > > What will happen when we'll want to bump to a new upstream version that > > hasn't been packaged by Debian ? > > As things stand now this is quite unlikely. The whois package Debian > maintainer and the upstream developer are the same person, Marco d'Itri. The > only upstream in-tree changelog file is at debian/changelog. > > > Sorry, but I definitely disagree here. Please use the real upstream. > > The real whois upstream README file says this: > > The canonical distribution point for releases of the program is > http://ftp.debian.org/debian/pool/main/w/whois/ . Fair enough. But I still find it completely weird to have the Github page as the "project home page" indicated in the Config.in file, and not use that as the upstream. And Arnout has put PATCH 1/3 back to the New state, while I still disagree with the approach being taken. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com