From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Analysis of build results for 2017-08-14
Date: Thu, 17 Aug 2017 09:09:41 +0200 [thread overview]
Message-ID: <20170817090941.1c8f98fe@windsurf> (raw)
In-Reply-To: <CANQCQpa+hXqae9hXk52+Ne0JBpTGUby5NSNnm2MyHma+cDHRew@mail.gmail.com>
Hello,
On Wed, 16 Aug 2017 21:00:26 -0500, Matthew Weber wrote:
> > I think it's best to put the empty _SITE check in an
> > ifneq ($(BR2_PRIMARY_SITE_ONLY),y)
>
> https://patchwork.ozlabs.org/patch/802290/
I know this is what Arnout suggested, but I'm not sure it's my
preferred fix. Indeed, what about instead dropping the:
if !BR2_PRIMARY_SITE_ONLY
...
endif
condition in Config.in that encloses the definition of BR2_GNU_MIRROR,
BR2_LUAROCKS_MIRROR, etc. ?
Even though I agree such variables are not used when
BR2_PRIMARY_SITE_ONLY=y, I don't see why we hide them. Removing this
condition in Config.in avoids the need for adding another condition in
pkg-generic.mk, and it seems more logical to me.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-08-17 7:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 6:31 [Buildroot] [autobuild.buildroot.net] Build results for 2017-08-14 Thomas Petazzoni
2017-08-15 12:20 ` [Buildroot] Analysis of build " Thomas Petazzoni
2017-08-15 12:58 ` Matthew Weber
2017-08-15 13:59 ` Thomas Petazzoni
2017-08-15 14:15 ` Matthew Weber
2017-08-16 20:22 ` Arnout Vandecappelle
2017-08-16 23:58 ` Matthew Weber
2017-08-17 2:00 ` Matthew Weber
2017-08-17 7:09 ` Thomas Petazzoni [this message]
2017-08-17 7:36 ` Arnout Vandecappelle
2017-08-17 12:01 ` Matthew Weber
2017-08-17 12:15 ` Arnout Vandecappelle
2017-08-16 20:35 ` Arnout Vandecappelle
2017-08-16 20:53 ` Thomas Petazzoni
2017-08-16 22:48 ` Arnout Vandecappelle
2017-08-17 7:47 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817090941.1c8f98fe@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox