From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next v2 1/1] package/lzo: switch to cmake
Date: Mon, 21 Aug 2017 23:29:34 +0200 [thread overview]
Message-ID: <20170821232934.016a4ce9@windsurf> (raw)
In-Reply-To: <8e8ea34e-3224-667a-5693-70a565dc49b7@mind.be>
Hello,
On Mon, 21 Aug 2017 21:35:30 +0200, Arnout Vandecappelle wrote:
> On 20-08-17 10:07, Bernd Kuhls wrote:
> > +LZO_SUPPORTS_IN_SOURCE_BUILD = NO
>
> Why doesn't it support in-source build? Best to explain that in the commit message.
It's actually quite common for cmake packages to not support in-tree
build:
package/gnuradio/gnuradio.mk:GNURADIO_SUPPORTS_IN_SOURCE_BUILD = NO
package/gr-osmosdr/gr-osmosdr.mk:GR_OSMOSDR_SUPPORTS_IN_SOURCE_BUILD = NO
package/jasper/jasper.mk:JASPER_SUPPORTS_IN_SOURCE_BUILD = NO
package/lapack/lapack.mk:LAPACK_SUPPORTS_IN_SOURCE_BUILD = NO
package/lensfun/lensfun.mk:LENSFUN_SUPPORTS_IN_SOURCE_BUILD = NO
package/libcodec2/libcodec2.mk:LIBCODEC2_SUPPORTS_IN_SOURCE_BUILD = NO
package/libssh/libssh.mk:LIBSSH_SUPPORTS_IN_SOURCE_BUILD = NO
package/lzo/lzo.mk:LZO_SUPPORTS_IN_SOURCE_BUILD = NO
package/racehound/racehound.mk:RACEHOUND_SUPPORTS_IN_SOURCE_BUILD = NO
package/sysdig/sysdig.mk:SYSDIG_SUPPORTS_IN_SOURCE_BUILD = NO
package/zxing-cpp/zxing-cpp.mk:ZXING_CPP_SUPPORTS_IN_SOURCE_BUILD = NO
and we've never really asked people to explain why. I wouldn't mind a
comment on top of the SUPPORTS_IN_SOURCE_BUILD = NO line in the .mk
file, but I'm not sure I want to make this absolutely necessary.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-08-21 21:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-20 8:07 [Buildroot] [PATCH/next v2 1/1] package/lzo: switch to cmake Bernd Kuhls
2017-08-21 0:33 ` Ricardo Martincoski
2017-08-21 19:35 ` Arnout Vandecappelle
2017-08-21 21:29 ` Thomas Petazzoni [this message]
2017-08-21 21:29 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821232934.016a4ce9@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox