Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libunwind: needs dynamic library support
Date: Mon, 21 Aug 2017 23:30:14 +0200	[thread overview]
Message-ID: <20170821233014.221cc34b@windsurf> (raw)
In-Reply-To: <20170820210151.2242-1-thomas.petazzoni@free-electrons.com>

Hello,

On Sun, 20 Aug 2017 23:01:51 +0200, Thomas Petazzoni wrote:
> libunwind configure script explicitly links libunwind against
> libgcc_s. libgcc_s is only guaranteed to be available for toolchains
> that supports dynamic linking: pure static linking toolchains only
> have libgcc.a, not libgcc_s.so.
> 
> Therefore, let's make libunwind unavailable on toolchains that lack
> dynamic linking support. We could potentially support linking with
> libgcc, but switching to libgcc_s was done upstream because libgcc was
> lacking some symbols on ARM
> (https://lists.nongnu.org/archive/html/libunwind-devel/2014-06/msg00024.html). Even
> though recent gcc versions seem to provide such symbols in libgcc.a,
> having libunwind available on static linking configurations is not a
> useful enough use-case to do the necessary research to find when this
> issue was fixed in gcc.
> 
> Since libunwind is not used as a mandatory dependency in any package,
> adding this !BR2_STATIC_LIBS dependency is trivial and nicely avoids
> the problematic situation.
> 
> This fixes two different autobuilder failures:
> 
>  - Gstreamer 1.x programs failing to link, because libunwind links
>    against libgcc_s that isn't available (static linking
>    configuration):
> 
>    http://autobuild.buildroot.net/results/9d4fbf7167e9afce0eef5c9e0cfd42c966ecba36/
> 
>  - Gmrender-resurrect, which fails to link, because GStreamer 1.x uses
>    some libunwind functionality, but does not take into account the
>    libunwind dependency in its .pc files (static linking
>    configuration):
> 
>    http://autobuild.buildroot.net/results/0a3a2485c187a000482c178f1e9c64dd716a858f/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  package/libunwind/Config.in | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2017-08-21 21:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-20 21:01 [Buildroot] [PATCH] libunwind: needs dynamic library support Thomas Petazzoni
2017-08-21 21:30 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170821233014.221cc34b@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox