Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] util-linux: add menu items for login utilities
Date: Wed, 23 Aug 2017 15:42:52 +0200	[thread overview]
Message-ID: <20170823154252.03f70fea@windsurf> (raw)
In-Reply-To: <20170819235533.18373-1-casantos@datacom.ind.br>

Hello,

On Sat, 19 Aug 2017 20:55:33 -0300, Carlos Santos wrote:

> +config BR2_PACKAGE_UTIL_LINUX_LOGIN_UTILS
> +	bool "login utilities"
> +	depends on BR2_USE_MMU # fork() (login, runuser, su, sulogin)
> +	depends on (BR2_ENABLE_LOCALE && BR2_USE_WCHAR) # linux-pam
> +	depends on !BR2_STATIC_LIBS
> +	depends on !BR2_TOOLCHAIN_USES_MUSL # linux-pam
> +	select BR2_PACKAGE_UTIL_LINUX_LAST
> +	select BR2_PACKAGE_UTIL_LINUX_LOGIN
> +	select BR2_PACKAGE_UTIL_LINUX_RUNUSER
> +	select BR2_PACKAGE_UTIL_LINUX_SU
> +	select BR2_PACKAGE_UTIL_LINUX_SULOGIN

I don't really see the need to keep this option. We have
BR2_PACKAGE_UTIL_LINUX_BINARIES, because it matches the upstream
--enable-all-programs option. But here,
BR2_PACKAGE_UTIL_LINUX_LOGIN_UTILS doesn't match anything provided by
upstream, it's just a random category created by Buildroot.

So let's get rid of this option, with appropriate Config.in.legacy
handling selecting all the individual tools, and only have sub-options
per tools, matching the --enable-<foo> options provided by util-linux
configure script.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-08-23 13:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-19 23:55 [Buildroot] [PATCH] util-linux: add menu items for login utilities Carlos Santos
2017-08-23 13:42 ` Thomas Petazzoni [this message]
2017-08-23 16:51   ` Carlos Santos
2017-08-24  3:58   ` [Buildroot] [PATCH 1/2] " Carlos Santos
2017-08-24  3:58     ` [Buildroot] [PATCH 2/2] util-linux: use a patch from upstream to fix ncursesw support Carlos Santos
2017-08-24 21:21       ` Thomas Petazzoni
2017-08-24 21:24     ` [Buildroot] [PATCH 1/2] util-linux: add menu items for login utilities Thomas Petazzoni
2017-08-25  3:19       ` [Buildroot] [PATCH v3] " Carlos Santos
2017-08-25 20:51         ` Arnout Vandecappelle
2017-08-25 21:26           ` [Buildroot] [PATCH v4] " Carlos Santos
2017-09-02  0:41             ` [Buildroot] [PATCH v5] " Carlos Santos
2017-09-02 20:49               ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170823154252.03f70fea@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox