From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/7] package/mesa3d: fix build issue with glibc >= 2.26
Date: Wed, 30 Aug 2017 22:49:10 +0200 [thread overview]
Message-ID: <20170830224910.048d0e59@windsurf.lan> (raw)
In-Reply-To: <20170827173606.13144-4-romain.naour@gmail.com>
Hello,
On Sun, 27 Aug 2017 19:36:02 +0200, Romain Naour wrote:
> ++/* This workaround is not necessary since Glibc 2.26
> ++ * https://sourceware.org/git/?p=glibc.git;a=commit;h=2072f5c34ede81dde9e0d953d57a0690a66b0f12
> ++ */
> ++#if (__GLIBC__ == 2 && __GLIBC_MINOR__ <= 25)
How does this behaves with uClibc and musl? I guess with uClibc it
should be fine, because it pretends to be glibc 2.2.
However, musl doesn't define __GLIBC__, so it means that this code,
that used to be defined for musl, we no longer be defined. Can check if
mesa3d still builds fine with musl after this change ? Or perhaps musl
didn't had the original issue ?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-08-30 20:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-27 17:35 [Buildroot] [PATCH 0/7] glibc: bump to 2.26 Romain Naour
2017-08-27 17:36 ` [Buildroot] [PATCH 1/7] package/gcc: fix build issue with glibc 2.26 Romain Naour
2017-08-27 17:36 ` [Buildroot] [PATCH 2/7] " Romain Naour
2017-08-27 17:36 ` [Buildroot] [PATCH 3/7] package/mesa3d: fix build issue with glibc >= 2.26 Romain Naour
2017-08-30 20:49 ` Thomas Petazzoni [this message]
2017-08-30 20:57 ` Romain Naour
2017-08-27 17:36 ` [Buildroot] [PATCH 4/7] package/jsoncpp: fix build " Romain Naour
2017-08-27 17:36 ` [Buildroot] [PATCH 5/7] package/glibc: needs kernel headers >= 3.10 on powerpc64le Romain Naour
2017-08-27 17:36 ` [Buildroot] [PATCH 6/7] package/gcc: enable float128 on powerpc64le with glibc >= 2.26 toolchains Romain Naour
2017-08-30 20:51 ` Thomas Petazzoni
2017-08-30 21:07 ` Romain Naour
2017-08-27 17:36 ` [Buildroot] [PATCH 7/7] package/glibc: bump to 2.26 Romain Naour
2017-08-28 5:18 ` [Buildroot] [PATCH 0/7] glibc: " Bernd Kuhls
2017-08-28 7:59 ` Romain Naour
2017-09-02 9:56 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830224910.048d0e59@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox