From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/scripts/check-bin-arch: ignore symbolic links
Date: Mon, 4 Sep 2017 16:04:01 +0200 [thread overview]
Message-ID: <20170904160401.6a8bb231@windsurf.lan> (raw)
In-Reply-To: <20170903142548.GC2786@scaer>
Hello,
On Sun, 3 Sep 2017 16:25:48 +0200, Yann E. MORIN wrote:
> > + # Skip symlinks. Some symlinks may have absolute paths as
> > + # target, pointing to host binaries while we're building.
> > + if [[ -L "${f}" ]]; then
>
> I don't like that we use the bashism [[...]] when the POSIX [...] works
> perfectly well. And we also use 'test' below, which is not very
> consistent...
Agreed, but there are already such tests in the script, so I just used
the same syntax. We can fix that up as a follow-up patch.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-09-04 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 14:09 [Buildroot] [PATCH] support/scripts/check-bin-arch: ignore symbolic links Thomas Petazzoni
2017-09-03 14:25 ` Yann E. MORIN
2017-09-04 14:04 ` Thomas Petazzoni [this message]
2017-09-04 14:03 ` Thomas Petazzoni
2017-10-16 21:45 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904160401.6a8bb231@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox