From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] mmc-utils: use upstream provided install target
Date: Wed, 6 Sep 2017 23:33:34 +0200 [thread overview]
Message-ID: <20170906233334.328e7d87@windsurf.lan> (raw)
In-Reply-To: <458a66622f1ede03edf340d7f05d52f971eabc79.1504510840.git.baruch@tkos.co.il>
Hello,
On Mon, 4 Sep 2017 10:40:40 +0300, Baruch Siach wrote:
> define MMC_UTILS_INSTALL_TARGET_CMDS
> - $(INSTALL) -D -m 0755 $(@D)/mmc $(TARGET_DIR)/usr/bin/mmc
> + prefix=$(TARGET_DIR) $(MAKE) -C $(@D) install
> endef
This is not entirely correct, for a few reasons: first, your patch
introduces a difference as the "mmc" program is now installed
in /bin/mmc and not /usr/bin/mmc, which isn't nice.
Also, it mis-uses prefix, as DESTDIR should be used. The correct
use is prefix=/usr (to override the default of /usr/local) and
DESTDIR=$(TARGET_DIR).
Best regards,
Thomas Petazzoni
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-09-06 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 7:40 [Buildroot] [PATCH] mmc-utils: use upstream provided install target Baruch Siach
2017-09-06 21:33 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906233334.328e7d87@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox