Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] msgpack: bump to version 2.1.5
Date: Sat, 9 Sep 2017 23:09:21 +0200	[thread overview]
Message-ID: <20170909230921.0c270d7a@windsurf.lan> (raw)
In-Reply-To: <20170907155108.3449-1-bradford@density.io>

Hello,

On Thu,  7 Sep 2017 11:51:08 -0400, Bradford Barr wrote:
> From: bradford barr <bradford@density.io>
> 
> Signed-off-by: bradford barr <bradford@density.io>

This needs a bigger commit log, because it's doing a lot more than a
version bump: the license is changing, and you introduce this "header
only" option.

> diff --git a/package/msgpack/Config.in b/package/msgpack/Config.in
> index b8e8213..e0626b2 100644
> --- a/package/msgpack/Config.in
> +++ b/package/msgpack/Config.in
> @@ -13,3 +13,15 @@ config BR2_PACKAGE_MSGPACK
>  comment "msgpack needs a toolchain w/ C++"
>  	depends on !BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4
> +
> +if BR2_PACKAGE_MSGPACK
> +
> +config BR2_PACKAGE_MSGPACK_HEADER_ONLY

Could you give a rational for adding this ?

> +	bool "header only"
> +	depends on BR2_INSTALL_LIBSTDCPP

Not needed, the main option already depends on this.

> +	help
> +	  MessagePack can be installed as a header only library.

And why would you do it ?

> -$(eval $(autotools-package))
> +MSGPACK_INSTALL_STAGING = YES
> +
> +ifeq ($(BR2_PACKAGE_MSGPACK_HEADER_ONLY),y)
> +MSGPACK_INSTALL_TARGET = NO
> +else
> +MSGPACK_INSTALL_TARGET = YES
> +endif

Passing MSGPACK_INSTALL_TARGET = NO is sufficient, since "YES" is the
default value.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-09-09 21:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-07 15:51 [Buildroot] [PATCH 1/1] msgpack: bump to version 2.1.5 Bradford Barr
2017-09-09 21:09 ` Thomas Petazzoni [this message]
     [not found]   ` <CAPpUvYg0OiL5tFaf9D3WBWJsxqeV5Pnx=F_Uk0o5TVeFZpcuHg@mail.gmail.com>
2017-09-12 14:18     ` Bradford Barr
2017-09-13 19:58       ` Arnout Vandecappelle
2017-09-13 20:40         ` Bradford Barr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170909230921.0c270d7a@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox