From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC v2] libvirt: new package
Date: Fri, 15 Sep 2017 02:09:06 +0200 [thread overview]
Message-ID: <20170915020906.7ea90b5e@windsurf> (raw)
In-Reply-To: <1505421391-11951-1-git-send-email-casantos@datacom.ind.br>
Hello,
On Thu, 14 Sep 2017 17:36:31 -0300, Carlos Santos wrote:
> +LIBVIRT_VERSION = 3.7.0
> +LIBVIRT_SITE = http://libvirt.org/sources
> +LIBVIRT_SOURCE = libvirt-$(LIBVIRT_VERSION).tar.xz
> +LIBVIRT_LICENSE = LGPL-2.1+
> +LIBVIRT_LICENSE_FILES = COPYING
> +# LIBVIRT_INSTALL_STAGING = YES
Commented line ?
> +LIBVIRT_DEPENDENCIES = libnl libtirpc libxml2 lvm2 yajl
> +
> +ifeq ($(BR2_PACKAGE_EUDEV),y)
> +LIBVIRT_DEPENDENCIES += eudev libpciaccess
> +endif
Why do you handle eudev specifically here? Isn't the udev
implementation in systemd not suitable?
I.e, I believe this should be:
ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
LIBVIRT_DEPENDENCIES += udev libpciaccess
endif
And of course, adjust Config.in accordingly.
> +LIBVIRT_CONF_ENV += \
> + CFLAGS="$(TARGET_CFLAGS) `$(PKG_CONFIG_HOST_BINARY) --cflags libtirpc`" \
> + LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs libtirpc`"
Why is libtirpc unconditionally necessary? The RPC implementation built
into the C library is not sufficient ?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-09-15 0:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 20:36 [Buildroot] [RFC v2] libvirt: new package Carlos Santos
2017-09-15 0:09 ` Thomas Petazzoni [this message]
2017-09-15 17:10 ` Carlos Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915020906.7ea90b5e@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox