From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] dash: enable line editting if libedit is selected.
Date: Thu, 28 Sep 2017 08:59:57 +0200 [thread overview]
Message-ID: <20170928085957.04978e60@windsurf.lan> (raw)
In-Reply-To: <816883822.11304783.1506543568981.JavaMail.zimbra@datacom.ind.br>
Hello,
On Wed, 27 Sep 2017 17:19:28 -0300 (BRT), Carlos Santos wrote:
> > This really looks like a "personal preference" configuration, that is
> > more relevant in a custom rootfs overlay, no?
>
> This is the default behavior of BusyBox's shell, which is used in 98.73%
> of the Buldroot installations, according to my statistics factory, so I
> think we should use it by default.
Hum, OK.
> >> +ifeq ($(BR2_PACKAGE_LIBEDIT),y)
> >> +DASH_DEPENDENCIES += libedit
> >> +DASH_CONF_OPTS += --with-libedit
> >> +DASH_POST_INSTALL_TARGET_HOOKS += DASH_INSTALL_PROFILE
> >
> > What about --without-libedit in an else case ?
>
> In the case else there is no libedit to which not to link. :-)
We always try to explicitly disable features, so that configure scripts
don't misdetect a system-installed libedit for example.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-09-28 6:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 16:41 [Buildroot] [PATCH 1/2] dash: bump to version 0.5.9.1 Carlos Santos
2017-09-27 16:41 ` [Buildroot] [PATCH 2/2] dash: enable line editting if libedit is selected Carlos Santos
2017-09-27 19:18 ` Thomas Petazzoni
2017-09-27 20:19 ` Carlos Santos
2017-09-28 6:59 ` Thomas Petazzoni [this message]
2017-09-28 11:54 ` Carlos Santos
2017-09-28 18:07 ` [Buildroot] [PATCH v2] " Carlos Santos
2018-02-04 11:07 ` Peter Korsgaard
2018-02-04 11:10 ` Peter Korsgaard
2017-09-27 19:17 ` [Buildroot] [PATCH 1/2] dash: bump to version 0.5.9.1 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928085957.04978e60@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox