Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] matchbox-lib: select dependency
Date: Mon, 2 Oct 2017 19:14:55 +0200	[thread overview]
Message-ID: <20171002171455.GE4753@scaer> (raw)
In-Reply-To: <192b3438-653d-c32f-53bb-234843ee8ab4@mind.be>

Arnout, All,

On 2017-10-02 15:35 +0200, Arnout Vandecappelle spake thusly:
> On 01-10-17 11:58, Yann E. MORIN wrote:
> > Select the library we build-depend on.
> > 
> > Add myself to developpers for matchbos packages.
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> >  DEVELOPERS                     | 1 +
> >  package/matchbox-lib/Config.in | 1 +
> >  2 files changed, 2 insertions(+)
> > 
> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index cedf5a6f84..5a1ca877de 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -1819,6 +1819,7 @@ F:	package/libinput/
> >  F:	package/libiscsi/
> >  F:	package/libseccomp/
> >  F:	package/linux-tools/
> > +F:	package/matchbox*
> >  F:	package/mesa3d-headers/
> >  F:	package/nbd/
> >  F:	package/nut/
> > diff --git a/package/matchbox-lib/Config.in b/package/matchbox-lib/Config.in
> > index e50a5436c1..d758ab35a8 100644
> > --- a/package/matchbox-lib/Config.in
> > +++ b/package/matchbox-lib/Config.in
> > @@ -1,4 +1,5 @@
> >  config BR2_PACKAGE_MATCHBOX_LIB
> >  	bool "matchbox-lib"
> > +	select BR2_PACKAGE_XLIB_LIBXEXT
> 
>  matchbox-lib also has a DEPENDENCIES on expat. expat is indeed selected by the
> top-level matchbox package, but that package doesn't actually have it in its
> DEPENDENCIES. So perhaps move expat as well?

Hmm... I did not see the expat issue, because as you said, matchbox does
select it.

I'll check whether it is needed in matchbox-lib or not, and will send an
appropriate patch.

>  Otherwise:
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Thanks! :-)

Regards,
Yann E. MORIN.

>  Regards,
>  Arnout
> 
> >  	help
> >  	  Matchbox common functionality library.
> > 
> 
> -- 
> Arnout Vandecappelle                          arnout at mind be
> Senior Embedded Software Architect            +32-16-286500
> Essensium/Mind                                http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2017-10-02 17:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-01  9:58 [Buildroot] [PATCH 0/2] package/matchbox: fixes Yann E. MORIN
2017-10-01  9:58 ` [Buildroot] [PATCH 1/2] matchbox-lib: select dependency Yann E. MORIN
2017-10-02 13:35   ` Arnout Vandecappelle
2017-10-02 17:14     ` Yann E. MORIN [this message]
2017-10-01  9:58 ` [Buildroot] [PATCH 2/2] package/matchbox-lib: correctly fix the .pc file Yann E. MORIN
2017-10-02 17:26   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171002171455.GE4753@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox