From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-download: make package name optional in github helper
Date: Thu, 5 Oct 2017 12:23:56 +0200 [thread overview]
Message-ID: <20171005122356.2b31e9b5@windsurf.home> (raw)
In-Reply-To: <26d3dc60-5a3a-0fce-f3cf-b75ee2670644@mind.be>
Hello,
On Wed, 4 Oct 2017 18:35:07 +0200, Arnout Vandecappelle wrote:
> As noticed by Peter, this was already wrong in the original patch: it only
> works if the github helper is used in a := assignment,
Doh? We're using the github helper almost exclusively in = assignments:
package/assimp/assimp.mk:ASSIMP_SITE = $(call github,assimp,assimp,$(ASSIMP_VERSION))
package/asterisk/asterisk.mk:ASTERISK_SITE = $(call github,asterisk,asterisk,$(ASTERISK_VERSION))
package/atest/atest.mk:ATEST_SITE = $(call github,amouiche,atest,$(ATEST_VERSION))
package/aufs/aufs.mk:AUFS_SITE = $(call github,sfjro,aufs4-standalone,$(AUFS_VERSION))
package/avrdude/avrdude.mk:AVRDUDE_SITE = $(call github,kcuzner,avrdude,$(AVRDUDE_VERSION))
package/axfsutils/axfsutils.mk:AXFSUTILS_SITE = $(call github,jaredeh,axfs,$(AXFSUTILS_VERSION))
package/azmq/azmq.mk:AZMQ_SITE = $(call github,zeromq,azmq,$(AZMQ_VERSION))
Am I missing something in your explanation ?
Or perhaps you meant "when the third argument is not passed, we need to
use a := assignment" ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-10-05 10:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 8:57 [Buildroot] [PATCH] pkg-download: make package name optional in github helper Ismael Luceno
2017-10-04 16:35 ` Arnout Vandecappelle
2017-10-05 10:13 ` Ismael Luceno
2017-10-05 17:50 ` Arnout Vandecappelle
2017-10-05 21:20 ` Ismael Luceno
2017-10-05 10:23 ` Thomas Petazzoni [this message]
2017-10-05 12:57 ` Arnout Vandecappelle
2017-10-05 10:22 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005122356.2b31e9b5@windsurf.home \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox