From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 10 Oct 2017 23:33:47 +0200 Subject: [Buildroot] [PATCH] support/run-tests: export download dir In-Reply-To: <20170917092028.5236-1-yann.morin.1998@free.fr> References: <20170917092028.5236-1-yann.morin.1998@free.fr> Message-ID: <20171010233347.5907a289@windsurf.lan> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Sun, 17 Sep 2017 11:20:28 +0200, Yann E. MORIN wrote: > Currently, the download directory, when specified with the -d option, is > only used to store the files downloaded by the testing infra, not those > downloaded by Buildroot. > > So, we end up with this situation: > > BR2_DL_DIR | -d DIR | test downloads | BR downloads > ------------+----------+------------------+-------------- > unset | unset | [error] | [error] > unset | set | in $(DIR) | in $(TOP_DIR)/dl > set | unset | in $(BR2_DL_DIR) | in $(BR2_DL_DIR) > set | set | in $(DIR) | in $(BR2_DL_DIR) > > This is not very consistent. > > We change the behaviour so that the value of -d always takes precedence, > and is used by Buildroot as well, giving this new behaviour: > > BR2_DL_DIR | -d DIR | test downloads | BR downloads > ------------+----------+------------------+-------------- > unset | unset | [error] | [error] > unset | set | in $(DIR) | in $(DIR) > set | unset | in $(BR2_DL_DIR) | in $(BR2_DL_DIR) > set | set | in $(DIR) | in $(DIR) > > Signed-off-by: "Yann E. MORIN" > Cc: Ricardo Martincoski > Cc: Thomas Petazzoni > --- > support/testing/run-tests | 1 + > 1 file changed, 1 insertion(+) Indeed, makes sense. Applied, thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com