Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] axel: bump to version 2.15
Date: Wed, 11 Oct 2017 23:48:16 +0200	[thread overview]
Message-ID: <20171011234816.00e5534b@windsurf.lan> (raw)
In-Reply-To: <20171011014129.32230-1-ismael@iodev.co.uk>

Hello,

Thanks for this update!

On Tue, 10 Oct 2017 22:41:29 -0300, Ismael Luceno wrote:

> -ifeq ($(BR2_SYSTEM_ENABLE_NLS),)
> -AXEL_DISABLE_I18N = --i18n=0
> +ifeq ($(BR2_PACKAGE_LIBRESSL),y)
> +AXEL_CONF_OPTS += --with-ssl
> +AXEL_DEPENDENCIES += libressl
> +else ifeq ($(BR2_PACKAGE_LIBRESSL),y)

This should be BR2_PACKAGE_OPENSSL

> +AXEL_LDFLAGS = -lpthread $(TARGET_NLS_LIBS)

Such a variable has no effect with the autotools-package
infrastructure, to it is useless.

So you probably want to check instead if it's still needed:

 - To check if -lpthread is needed, build with a glibc toolchain
   toolchain, for example
   support/config-fragments/autobuild/br-arm-cortex-a9-glibc.config

 - To check if $(TARGET_NLS_LIBS) is needed, build with a uClibc
   toolchain, for example
   support/config-fragments/autobuild/br-arm-full.config, and enable
   BR2_SYSTEM_ENABLE_NLS.

Ideally, none of these should be needed, and the configure script of
axel should automatically figure out if it needs to link against
-lpthread and/or -lintl.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2017-10-11 21:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-11  1:41 [Buildroot] [PATCH] axel: bump to version 2.15 Ismael Luceno
2017-10-11 21:48 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171011234816.00e5534b@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox