Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] opencv3: add support for tbb
Date: Thu, 12 Oct 2017 22:46:38 +0200	[thread overview]
Message-ID: <20171012224638.20c6a202@windsurf.home> (raw)
In-Reply-To: <20170928235043.31891-3-bradford@density.io>

Hello,

On Thu, 28 Sep 2017 19:50:43 -0400, Bradford Barr wrote:

> diff --git a/package/opencv3/0001-tbb-debug.patch b/package/opencv3/0001-tbb-debug.patch
> new file mode 100644
> index 0000000..808483d
> --- /dev/null
> +++ b/package/opencv3/0001-tbb-debug.patch
> @@ -0,0 +1,27 @@
> +From a56d7592f0f2f63a84e2159171a784026cc99986 Mon Sep 17 00:00:00 2001
> +From: bradford barr <bradford@density.io>
> +Date: Thu, 28 Sep 2017 17:31:41 -0400
> +Subject: [PATCH] TBB Debug Release
> +
> +OpenCV fails to detect tbb on a debug build if the platform has only installed
> +debug libraries.  This PR adds an additional check to the tbb detect logic for
> +systems that only install tbb debug and not both tbb debug and release.

This would be unnecessary if you drop the "debug" support in the tbb
package.

> +config BR2_PACKAGE_OPENCV3_WITH_TBB
> +	bool "tbb support"
> +	select BR2_PACKAGE_TBB

You forgot to propagate the dependencies of tbb here (and don't forget
to add the corresponding Config.in comment).

Otherwise, looks good to me.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2017-10-12 20:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-28 23:50 [Buildroot] [PATCH v2 0/2] TBB and OpenCV3 Bradford Barr
2017-09-28 23:50 ` [Buildroot] [PATCH v2 1/2] tbb: new package Bradford Barr
2017-10-06 16:27   ` Yegor Yefremov
2017-10-12 20:45   ` Thomas Petazzoni
2017-10-12 21:12     ` Bradford Barr
2017-10-12 21:14       ` Bradford Barr
2017-10-12 21:21       ` Thomas Petazzoni
2017-09-28 23:50 ` [Buildroot] [PATCH v2 2/2] opencv3: add support for tbb Bradford Barr
2017-10-12 20:46   ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171012224638.20c6a202@windsurf.home \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox