From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] axel: bump to version 2.15
Date: Mon, 16 Oct 2017 21:23:52 +0200 [thread overview]
Message-ID: <20171016212352.4707159c@windsurf.lan> (raw)
In-Reply-To: <20171016191127.14704-1-ismael@iodev.co.uk>
Hello,
On Mon, 16 Oct 2017 16:11:27 -0300, Ismael Luceno wrote:
> - Change upstream URL.
> - Add optional dependency on libressl/openssl.
> - Switch to autotools-package.
>
> Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
> ---
You forgot to add a changelog here, describing what changes since v1.
> -AXEL_VERSION = 2.4
> -AXEL_SITE = http://sources.buildroot.net
> +AXEL_VERSION = 2.15
> +AXEL_SITE = https://github.com/axel-download-accelerator/axel/releases/download/v$(AXEL_VERSION)
> +AXEL_SOURCE = axel-$(AXEL_VERSION).tar.xz
> AXEL_LICENSE = GPL-2.0+
> AXEL_LICENSE_FILES = COPYING
> AXEL_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
> -AXEL_LDFLAGS = -lpthread $(TARGET_NLS_LIBS)
>
> -ifeq ($(BR2_SYSTEM_ENABLE_NLS),)
> -AXEL_DISABLE_I18N = --i18n=0
> -endif
> -
> -define AXEL_CONFIGURE_CMDS
> - (cd $(@D); \
> - ./configure \
> - --prefix=/usr \
> - --debug=1 \
> - $(AXEL_DISABLE_I18N) \
> - )
> -endef
> +AXEL_CFLAGS = -D_POSIX_C_SOURCE=200112L
> +AXEL_CONF_OPTS = \
> + ac_cv_prog_cc_c99=-std=c99 \
> + CFLAGS="$(TARGET_CFLAGS) $(AXEL_CFLAGS)"
Why do you need these? It should be explained in the commit log, or
perhaps even better with a short comment.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-10-16 19:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 19:11 [Buildroot] [PATCH v2] axel: bump to version 2.15 Ismael Luceno
2017-10-16 19:23 ` Thomas Petazzoni [this message]
2017-10-16 19:53 ` Ismael Luceno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016212352.4707159c@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox