From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC, v2, 1/4] package/go: fixing crosscompilation settings
Date: Thu, 19 Oct 2017 21:54:25 +0200 [thread overview]
Message-ID: <20171019215425.65df2006@windsurf.home> (raw)
In-Reply-To: <CA+h8R2osm25=0sGt9hjV1wKoY6WuKbnVRm8FLiMfCaeC6kouFw@mail.gmail.com>
Hello,
On Thu, 19 Oct 2017 13:20:14 -0400, Christian Stewart wrote:
> Tested, works fine. Signing off on the first commit in the series only.
>
> Signed-off-by: Christian Stewart <christian@paral.in>
So, this should be a Tested-by I guess.
Signed-off-by is added if you wrote the code or convey the code.
Tested-by is if you tested it without necessarily looking at the
code/reviewing it, Acked-by if you agree with it (it's a strong
statement), Reviewed-by if you reviewed it (it's somewhat weaker than
Acked-by).
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-10-19 19:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 17:20 [Buildroot] [RFC, v2, 1/4] package/go: fixing crosscompilation settings Christian Stewart
2017-10-19 19:54 ` Thomas Petazzoni [this message]
2017-10-19 20:17 ` Christian Stewart
-- strict thread matches above, loose matches on Subject: below --
2017-10-16 17:08 [Buildroot] [RFC v2 " Angelo Compagnucci
2017-10-21 19:51 ` Thomas Petazzoni
2017-10-22 22:48 ` Peter Korsgaard
2017-10-25 7:41 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019215425.65df2006@windsurf.home \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox