From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] raspberrypi: post-image.sh fix gpu_mem option
Date: Sat, 21 Oct 2017 21:37:25 +0200 [thread overview]
Message-ID: <20171021213725.67daa97a@windsurf> (raw)
In-Reply-To: <20171021135214.18552-1-gael.portay@savoirfairelinux.com>
Hello,
On Sat, 21 Oct 2017 09:52:14 -0400, Ga?l PORTAY wrote:
> The gpu_mem option is not using the proper option argument which causes sed to
> fail.
>
> + case "${arg}" in
> + gpu_mem=ome/gportay/output-rpi3-qtwe/images
> + sed -e '/^ome/gportay/output-rpi3-qtwe/images=/s,=.*,=ome/gportay/output-rpi3-qtwe/images,' -i /home/gportay/output-rpi3-qtwe/images/rpi-firmware/config.txt
> sed: -e expression #1, char 8: extra characters after command
> + case "${arg}" in
> + gpu_mem=ome/gportay/output-rpi3-qtwe/images
> + sed -e '/^ome/gportay/output-rpi3-qtwe/images=/s,=.*,=ome/gportay/output-rpi3-qtwe/images,' -i /home/gportay/output-rpi3-qtwe/images/rpi-firmware/config.txt
> sed: -e expression #1, char 8: extra characters after command
>
> The issue comes from the use of $1 instead of $arg to extract the gpu_mem
> value. $1 is the $(BINARIES_DIR) which leads to a sed expression error.
>
> Also, it adds the error flag to the shell script to prevent from such situation
> and terminate the build in error.
>
> Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
> ---
> board/raspberrypi/post-image.sh | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-10-21 19:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-21 13:52 [Buildroot] [PATCH] raspberrypi: post-image.sh fix gpu_mem option Gaël PORTAY
2017-10-21 19:30 ` Yann E. MORIN
2017-10-21 19:37 ` Thomas Petazzoni [this message]
2017-10-21 22:24 ` Gaël PORTAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171021213725.67daa97a@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox