From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] lua-sdl2: refactor with cmake
Date: Sun, 22 Oct 2017 14:14:59 +0200 [thread overview]
Message-ID: <20171022141459.499df9c5@windsurf> (raw)
In-Reply-To: <20170612082144.25846-1-francois.perrad@gadz.org>
Hello,
On Mon, 12 Jun 2017 10:21:44 +0200, Francois Perrad wrote:
> that allows optional dependencies
>
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> package/lua-sdl2/0001-avoid-host-includes.patch | 18 +++++++++++++
> package/lua-sdl2/Config.in | 4 ---
> package/lua-sdl2/lua-sdl2.hash | 2 +-
> package/lua-sdl2/lua-sdl2.mk | 36 +++++++++++++++++++++----
> 4 files changed, 50 insertions(+), 10 deletions(-)
> create mode 100644 package/lua-sdl2/0001-avoid-host-includes.patch
I've applied, but after fixing a few things:
- The package should depend on luainterpreter, not lua, so that it
works correctly when LuaJIT is used.
- The patch should have been Git formatted (upstream uses Git), and
instead of commenting some code, the patch should just remove it.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2017-10-22 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 8:21 [Buildroot] [PATCH] lua-sdl2: refactor with cmake Francois Perrad
2017-10-22 12:14 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171022141459.499df9c5@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox