From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] qt5base: remove nostrip qmake.conf config option
Date: Fri, 27 Oct 2017 19:30:47 +0200 [thread overview]
Message-ID: <20171027193047.388c0893@gmx.net> (raw)
In-Reply-To: <20171027183441.529e95d6@windsurf.lan>
Hello Thomas,
On Fri, 27 Oct 2017 18:34:41 +0200, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Fri, 27 Oct 2017 18:05:22 +0200, Peter Seiderer wrote:
> > Re-enables the qmake default behaviour for qmake projects living
> > out-side of buildroot (debug build with-out strip, release build with
> > strip).
> >
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>
> What is the reasoning for this?
>
> I think we do want qmake to *not* strip anything, and leave it to
> Buildroot's BR2_STRIP_strip option to decide whether stripping should
> happen or not.
Mhhh, I see the reason for the in-buildroot usage of qmake, but still a bit
annoying for out-of-buildroot usage (but maybe a 'qmake CONIFG-=nostrip'
works here), would still prefer to keep the simple/original qmake
default and (maybe) add an additional 'CONFIG+=nostrip' to all in-buildroot
qmake usages?
Regards,
Peter
>
> Thanks!
>
> Thomas
next prev parent reply other threads:[~2017-10-27 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 16:05 [Buildroot] [PATCH v1] qt5base: remove nostrip qmake.conf config option Peter Seiderer
2017-10-27 16:34 ` Thomas Petazzoni
2017-10-27 17:30 ` Peter Seiderer [this message]
2017-10-27 17:49 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027193047.388c0893@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox