Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RESEND PATCH v4] libostree: new package
Date: Sun, 29 Oct 2017 15:45:13 +0100	[thread overview]
Message-ID: <20171029154513.487050d8@windsurf> (raw)
In-Reply-To: <p5pgcexorq.ln2@ID-313208.user.individual.net>

Hello,

On Sun, 29 Oct 2017 12:03:53 +0100, Bernd Kuhls wrote:
> Hi Marcus,

First of all Bernd, thanks a lot for your detailed review! Everything
is obviously correct in your review, and needs to be addressed by
Marcus. However, there is just one point that needs clarification.

> Please add openssl as optional dependency:
> 
> ifeq ($(BR2_PACKAGE_OPENSSL),y)
> LIBOSTREE_CONF_OPTS += --with-openssl
> LIBOSTREE_DEPENDENCIES += openssl
> else
> LIBOSTREE_CONF_OPTS += --without-openssl
> endif
> 
> Same for avahi, libarchive, libcurl, libsoup and systemd.

Adding support for optional dependencies is not a strict requirement,
as long as the corresponding features are explicitly disabled.

I.e, for each optional dependency, Marcus has the choice of:

 - Supporting it, by enabling the dependency if it's available in
   Buildroot

 - Disabling explicitly the optional dependency by passing the
   appropriate --disable-<foo>

Indeed, we don't want to ask our contributors to support all possible
optional dependencies. It might be a lot of work, and the contributor
may not necessarily care about such optional dependencies. Hence,
disabling a dependency explicitly is acceptable.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-10-29 14:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-29  9:37 [Buildroot] [RESEND PATCH v4] libostree: new package Marcus Folkesson
2017-10-29 11:03 ` Bernd Kuhls
2017-10-29 14:45   ` Thomas Petazzoni [this message]
2017-10-29 20:19   ` Marcus Folkesson
2017-10-29 12:40 ` Bernd Kuhls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171029154513.487050d8@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox