From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] openssh: fix getpagesize() related static linking issue
Date: Wed, 1 Nov 2017 10:47:00 +0100 [thread overview]
Message-ID: <20171101104700.036fad1f@windsurf> (raw)
In-Reply-To: <20171030224555.3220-1-peter@korsgaard.com>
Hello,
On Mon, 30 Oct 2017 23:45:55 +0100, Peter Korsgaard wrote:
> Fixes:
> http://autobuild.buildroot.net/results/8cc/8cc30818a400c7a392a3de787cabc9cd8425495f/
>
> The configure script checks for getpagesize() and sets HAVE_GETPAGESIZE in
> config.h, but bsd-getpagesize.c forgot to include includes.h (which
> indirectly includes config.h) so the checks always fails, causing linker
> issues when linking statically on systems with getpagesize().
>
> Fix it by including includes.h.
>
> Patch submitted upstream:
> https://lists.mindrot.org/pipermail/openssh-unix-dev/2017-October/036413.html
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> ...pat-bsd-getpagesize.c-include-includes.h-.patch | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 package/openssh/0005-openbsd-compat-bsd-getpagesize.c-include-includes.h-.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-11-01 9:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 22:45 [Buildroot] [PATCH] openssh: fix getpagesize() related static linking issue Peter Korsgaard
2017-11-01 9:47 ` Thomas Petazzoni [this message]
2017-11-26 9:12 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101104700.036fad1f@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox