[Buildroot] [PATCH 1/4] package/openobex: disable on Blackfin

[Waldemar Brodkorb <wbx@openadk.org>]

Hi Thomas,
Thomas Petazzoni wrote,

> Hello,
> 
> On Wed,  1 Nov 2017 21:11:34 +0100, Samuel Martin wrote:
> > Openobex uses accept4 syscall, which is not available on Blackfin flavored uclibc.
> > So, diasble openobex on blackfin (do not add extra checks on the c-library since
> > uclibc is the only choice for Blackfin).
> > 
> > Fixed:
> >   http://autobuild.buildroot.net/results/78e033fe9f43845581a5d87b21a8451f67520e44
> > 
> > Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> > ---
> >  package/openobex/Config.in | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/package/openobex/Config.in b/package/openobex/Config.in
> > index e611b8d803..4a4dc214ef 100644
> > --- a/package/openobex/Config.in
> > +++ b/package/openobex/Config.in
> > @@ -1,5 +1,6 @@
> >  config BR2_PACKAGE_OPENOBEX
> >  	bool "openobex"
> > +	depends on !BR2_bfin
> >  	help
> >  	  Free open source implementation of the Object Exchange (OBEX)
> >  	  protocol.
> 
> What about the Config.in comment, and the reverse dependencies of
> BR2_PACKAGE_OPENOBEX ?
> 
> Also, I'd like to hear from Waldemar about accept4 availability on
> Blackfin/uClibc-ng.

For me it looks like a uClibc bug.
When socketcalls.c was converted to use cancel.h for syscall
cancellation (19607f1113ef9916a0a0ac2bf99b5bc32526f0de)
it seems accept4 was left out for no specific reason.

For Linuxthreads the syscall wrapper for accept4 isn't compiled in.
I think for NPTL we do not see the issue.

I am going to sent out a patch soon.

best regards
 Waldemar