Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] qt5: remove Qt Quick dependency on opengl
Date: Thu, 2 Nov 2017 21:58:11 +0100	[thread overview]
Message-ID: <20171102205811.GC30054@scaer> (raw)
In-Reply-To: <bfb99fd2-5855-fd21-0ee1-00b28a7113d7@microchip.com>

Joshua, All,

On 2017-11-02 11:32 -0700, Joshua Henderson spake thusly:
> On 11/02/2017 10:18 AM, Yann E. MORIN wrote:
> > On 2017-11-02 17:22 +0100, S?bastien Szymanski spake thusly:
> >> From: Joshua Henderson <joshua.henderson@microchip.com>
> >>
> >> Qt Quick should no longer depend on opengl, and instead fallback to the limited
> >> functionality software renderer as a replacement [1] when not available. This
> >> also pulls a qt5declarative patch into 5.9.2 to fix examples compiling without
> >> opengl.
[--SNIP--]
> >> +Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> >> +---
> >> + examples/quick/quick.pro | 5 ++++-
> >> + 1 file changed, 4 insertions(+), 1 deletion(-)
> >> +
> >> +diff --git a/examples/quick/quick.pro b/examples/quick/quick.pro
> >> +index 445dfb0fa..26ca0138e 100644
> >> +--- a/examples/quick/quick.pro
> >> ++++ b/examples/quick/quick.pro
> >> +@@ -36,7 +36,10 @@ qtConfig(opengl(es1|es2)?) {
> >> + # Widget dependent examples
> >> + qtHaveModule(widgets) {
> >> +     SUBDIRS += embeddedinwidgets
> >> +-    qtHaveModule(quickwidgets): SUBDIRS += quickwidgets
> >> ++    # OpenGL Support Required
> >> ++    qtConfig(opengl(es1|es2)?) {
> >> ++        qtHaveModule(quickwidgets): SUBDIRS += quickwidgets
> > 
> > Upstream has a different patch, as commit fa52bb665d6b. Can you use that
> > instead of your own?
> > 
> 
> Looks like it.  I'll re-spin using that patch from the 5.10 branch.  I originally
> copied this from the existing 5.6.3 patch, so I'll see if the same patch fits
> there as well.

Ah, right, we already had it for 5.6.3 (I did not even thought of
looking).

But we do not want to backport the upstream patch to 5.6.3, because they
are not the same license, so we want to keep our own.

Regards,
Yann E. MORIN.

> S?bastien, thanks for adding that qt5virtualkeyboard can also support no opengl.
> Looks good.
> 
> Josh
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2017-11-02 20:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02 16:22 [Buildroot] [PATCH 1/1] qt5: remove Qt Quick dependency on opengl Sébastien Szymanski
2017-11-02 17:18 ` Yann E. MORIN
2017-11-02 18:32   ` Joshua Henderson
2017-11-02 20:58     ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171102205811.GC30054@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox