From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] packages/gpm: Fix FTBFS with glibc 2.26
Date: Thu, 2 Nov 2017 21:23:04 +0100 [thread overview]
Message-ID: <20171102212304.00451a37@windsurf> (raw)
In-Reply-To: <20171102194834.30515-1-petr.vorel@gmail.com>
Hello,
Thanks for providing a fix for this problem!
On Thu, 2 Nov 2017 20:48:34 +0100, Petr Vorel wrote:
> Use sigemptyset API instead of __sigemptyset
> __sigemptyset has been removed from glibc public
> API headers in upcoming (2.26) release onwards
>
> Patch taken from
> https://github.com/telmich/gpm/pull/20/commits/fdc42770596e25749f7e2ce0ea97882177397167
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---
> Patch also has been adopted by Fedora:
> http://pkgs.fedoraproject.org/cgit/rpms/gpm.git/commit/?id=dbf661f05db3f83ed1f3e9d86a368a4811d3a971
> ---
> ...-sigemptyset-API-instead-of-__sigemptyset.patch | 32 ++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
> create mode 100644 package/gpm/0004-Use-sigemptyset-API-instead-of-__sigemptyset.patch
A few things were not entirely correct:
- The commit log should not have a Signed-off-by from Khem
- The patch description should have had your Signed-off-by
- The commit log should have included a reference to an autobuilder
failure
I've applied after fixing those minor nits.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2017-11-02 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 19:48 [Buildroot] [PATCH 1/1] packages/gpm: Fix FTBFS with glibc 2.26 Petr Vorel
2017-11-02 20:23 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102212304.00451a37@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox