Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Duskett <aduskett@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] openntpd: add check for LibreSSL.
Date: Wed,  8 Nov 2017 08:04:59 -0500	[thread overview]
Message-ID: <20171108130459.25412-2-aduskett@gmail.com> (raw)
In-Reply-To: <20171108130459.25412-1-aduskett@gmail.com>

Openntp looks for a crypto library with tls_config_set_ca_mem, which is
available in LibreSSL but not OpenSSL. If tls_config_set_ca_mem is found,
crypto support is added to the build.

Because this is not currently checked, crypto support might not be added
due to the order of the build. Add a small check to see if
BR2_PACKAGE_LIBRESSL is selected, and if so, add a dependency for it.

Also add a note about this in the Config.in help section.

Signed-off-by: Adam Duskett <aduskett@gmail.com>
---
 package/openntpd/Config.in   | 3 +++
 package/openntpd/openntpd.mk | 6 ++++++
 2 files changed, 9 insertions(+)

diff --git a/package/openntpd/Config.in b/package/openntpd/Config.in
index 1b856c03b8..5f8c9e8549 100644
--- a/package/openntpd/Config.in
+++ b/package/openntpd/Config.in
@@ -9,6 +9,9 @@ config BR2_PACKAGE_OPENNTPD
 	  to remote NTP servers and can act as NTP server itself,
 	  redistributing the local clock. It just works.
 
+	  Note: Cryto support is only available with the LibreSSL ssl
+	  library.
+
 	  http://www.openntpd.org/
 
 comment "openntpd needs a toolchain w/ NPTL"
diff --git a/package/openntpd/openntpd.mk b/package/openntpd/openntpd.mk
index b5a2559008..d53eed29de 100644
--- a/package/openntpd/openntpd.mk
+++ b/package/openntpd/openntpd.mk
@@ -11,6 +11,12 @@ OPENNTPD_LICENSE_FILES = COPYING
 # Patching include/Makefile.am
 OPENNTPD_AUTORECONF = YES
 
+# Openntpd searches for tls_config_set_ca_mem which is only available
+# in LibreSSL
+ifeq ($(BR2_PACKAGE_LIBRESSL),y)
+OPENNTPD_DEPENDENCIES += openssl
+endif
+
 # openntpd uses pthread functions for arc4random emulation but forgets
 # to use -pthread
 OPENNTPD_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -pthread"
-- 
2.13.6

  reply	other threads:[~2017-11-08 13:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08 13:04 [Buildroot] [PATCH 1/2] openntpd: update to 6.2p3 Adam Duskett
2017-11-08 13:04 ` Adam Duskett [this message]
2017-11-22 22:10   ` [Buildroot] [PATCH 2/2] openntpd: add check for LibreSSL Thomas Petazzoni
2017-11-08 13:31 ` [Buildroot] [PATCH 1/2] openntpd: update to 6.2p3 Baruch Siach
2017-11-19 21:50   ` Adam Duskett
2017-11-20  5:11     ` Baruch Siach
2017-11-22 21:54       ` Thomas Petazzoni
2017-11-22 21:55 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171108130459.25412-2-aduskett@gmail.com \
    --to=aduskett@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox