From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Wed, 15 Nov 2017 22:22:57 +0100 Subject: [Buildroot] [PATCH 1/1] libupnp: add 1.8.3 version In-Reply-To: References: <20171114193821.25188-1-fontaine.fabrice@gmail.com> <20171115134342.60226366@windsurf.lan> Message-ID: <20171115222257.10defebb@windsurf.lan> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Wed, 15 Nov 2017 22:04:10 +0100, Fabrice Fontaine wrote: > > > +choice > > > + prompt "libupnp version" > > > + default BR2_PACKAGE_LIBUPNP_1_6 > > > + help > > > + Select the version of libupnp API you wish to use. > > > + > > > +config BR2_PACKAGE_LIBUPNP_1_6 > > > + bool "libupnp 1.6.x" > > > + > > > +config BR2_PACKAGE_LIBUPNP_1_8 > > > + bool "libupnp 1.8.x" > > > + > > > +endchoice > > > > I believe we should perhaps instead add a separate libupnp18 package, > > all those "depends on" to decide which package should be visible > > depending on the version of libupnp that is currently selected are a > > bit annoying. But don't rewrite your patch right now: wait for other > > Buildroot developers to give their opinion on this matter. > > > > Is it possible to install both libupnp 1.6 and libupnp 1.8 in the same > > system without any conflict ? > > > Unfortunately no, it was possible in 1.8.0 and 1.8.1 but we had to rollback > due to the vlc developer who wasn't happy with this change: > https://github.com/mrjimenez/pupnp/commit/07f504c61bd9e4d93eb3d373ffc852 > 7cafe0b9af OK, the reasoning makes sense. What is the transition plan ? Will the different Buildroot packages that use the 1.6 version be upgraded to use 1.8 at some point in the reasonably near future ? Or will we have to keep both versions forever ? Peter, Arnout, what are your thoughts on how to handle this? Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com