Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 2/3] package/feh: Cleanup build configuration
Date: Thu, 16 Nov 2017 11:04:58 +0100	[thread overview]
Message-ID: <20171116100459.5801-2-petr.vorel@gmail.com> (raw)
In-Reply-To: <20171116100459.5801-1-petr.vorel@gmail.com>

* build in parallel
* use TARGET_CONFIGURE_OPTS
* cleanup FEH_INSTALL_TARGET_CMDS

Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
 package/feh/feh.mk | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/package/feh/feh.mk b/package/feh/feh.mk
index 7211dc7bdd..3442f57197 100644
--- a/package/feh/feh.mk
+++ b/package/feh/feh.mk
@@ -12,13 +12,12 @@ FEH_LICENSE = MIT
 FEH_LICENSE_FILES = COPYING
 
 define FEH_BUILD_CMDS
-	$(TARGET_MAKE_ENV) CFLAGS="$(TARGET_CFLAGS) -std=gnu99" $(MAKE1) \
-		CC="$(TARGET_CC) $(TARGET_LDFLAGS)" -C $(@D) all
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) CFLAGS="$(TARGET_CFLAGS) -std=gnu99" \
+		$(MAKE) -C $(@D) all
 endef
 
 define FEH_INSTALL_TARGET_CMDS
-	$(TARGET_MAKE_ENV) $(MAKE1) CC="$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) " \
-		PREFIX=/usr DESTDIR=$(TARGET_DIR) -C $(@D) install
+	$(TARGET_MAKE_ENV) $(MAKE) PREFIX=/usr DESTDIR=$(TARGET_DIR) -C $(@D) install
 endef
 
 $(eval $(generic-package))
-- 
2.15.0

  reply	other threads:[~2017-11-16 10:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16 10:04 [Buildroot] [PATCH v3 1/3] package/feh: Fix build issue with some older cross-compilers Petr Vorel
2017-11-16 10:04 ` Petr Vorel [this message]
2017-11-16 10:04 ` [Buildroot] [PATCH v3 3/3] package/feh: Bump to version 2.22.2 Petr Vorel
2017-12-01 21:23 ` [Buildroot] [PATCH v3 1/3] package/feh: Fix build issue with some older cross-compilers Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171116100459.5801-2-petr.vorel@gmail.com \
    --to=petr.vorel@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox