From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] freerdp: fix wayland client dependency chain failure
Date: Mon, 20 Nov 2017 08:47:57 +0100 [thread overview]
Message-ID: <20171120084757.04cf0411@windsurf> (raw)
In-Reply-To: <20171119214852.27459-1-Adamduskett@outlook.com>
Hello,
+Yann in Cc.
On Sun, 19 Nov 2017 16:48:52 -0500, Adam Duskett wrote:
> If the wayland client is selected, freerdp depends on libxkbcommon without
> depending on it in the mk file.
>
> Fixes:
> http://autobuild.buildroot.net/results/dc3/dc3e11f7076a8355f3d2f9cb49c6325dcf7084bd
> Signed-off-by: Adam Duskett <Adamduskett@outlook.com>
> ---
> package/freerdp/freerdp.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/freerdp/freerdp.mk b/package/freerdp/freerdp.mk
> index 69a89a190c..29c35164c3 100644
> --- a/package/freerdp/freerdp.mk
> +++ b/package/freerdp/freerdp.mk
> @@ -207,6 +207,10 @@ else
> FREERDP_CONF_OPTS += -DWITH_WAYLAND=OFF
> endif
>
> +ifeq ($(BR2_PACKAGE_FREERDP_CLIENT_WL),y)
> +FREERDP_DEPENDENCIES += libxkbcommon
> +endif
https://git.buildroot.org/buildroot/commit/?id=c2824fba2f2f4df6c1e0273fa546a203d1e6d5ac
already makes libxkbcommon a dependency of freerdp when wayland is
enabled. Isn't this sufficient ?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-11-20 7:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-19 21:48 [Buildroot] [PATCH 1/1] freerdp: fix wayland client dependency chain failure Adam Duskett
2017-11-20 7:47 ` Thomas Petazzoni [this message]
2017-11-20 21:14 ` Yann E. MORIN
2017-11-25 17:16 ` Adam Duskett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120084757.04cf0411@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox