From: Adam Duskett <aduskett@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [NEXT v3 5/8] libpjsip: add dependency-less codecs
Date: Mon, 20 Nov 2017 13:09:02 -0500 [thread overview]
Message-ID: <20171120180905.5903-5-aduskett@gmail.com> (raw)
In-Reply-To: <20171120180905.5903-1-aduskett@gmail.com>
libpjsip has several codecs, all of which can be disabled or enabled
individually. A few reasons for adding each codec as an individual choice
are:
1) Many products might not want some of the more obscure codecs such as
ILBC or L16.
2) libpjsip has functions that will enumerate all the codecs that were built.
If all the codecs where built, this would require a developer to have to
parse out the codecs they don't want.
As such, turn libpjsip into a menuconfig and add each supported codec as an
individual choice.
Start with the codecs that are built into libpjsip and have no external
dependencies. These codecs are:
- G.711
- G.722
- G.722.1
- iLBC
- L16
Signed-off-by: Adam Duskett <aduskett@gmail.com>
---
Changes v1 -> v2:
- Combine all dependency-less codecs into a single patch.
- Add a more-detailed commit message explaining the reasoning for
enabling each codec as a individual option. (Arnout)
Changes v2 -> v3:
- None
package/libpjsip/Config.in | 17 +++++++++++++++++
package/libpjsip/libpjsip.mk | 32 +++++++++++++++++++++++++++-----
2 files changed, 44 insertions(+), 5 deletions(-)
diff --git a/package/libpjsip/Config.in b/package/libpjsip/Config.in
index 80b94e4..7fb5a87 100644
--- a/package/libpjsip/Config.in
+++ b/package/libpjsip/Config.in
@@ -44,6 +44,23 @@ config BR2_PACKAGE_LIBPJSIP_V4L2
comment "v4l2 support needs headers >= 3.0"
depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
+comment "dependency-less codecs"
+
+config BR2_PACKAGE_LIBPJSIP_CODEC_G711
+ bool "G.711"
+
+config BR2_PACKAGE_LIBPJSIP_CODEC_G722
+ bool "G.722"
+
+config BR2_PACKAGE_LIBPJSIP_CODEC_G7221
+ bool "G.722.1"
+
+config BR2_PACKAGE_LIBPJSIP_CODEC_ILBC
+ bool "iLBC"
+
+config BR2_PACKAGE_LIBPJSIP_CODEC_L16
+ bool "L16"
+
endif #BR2_PACKAGE_LIBPJSIP
comment "libpjsip needs a toolchain w/ C++, threads"
diff --git a/package/libpjsip/libpjsip.mk b/package/libpjsip/libpjsip.mk
index 6de12e3..48edf62 100644
--- a/package/libpjsip/libpjsip.mk
+++ b/package/libpjsip/libpjsip.mk
@@ -30,15 +30,10 @@ LIBPJSIP_CONF_OPTS = \
--disable-speex-aec \
--disable-resample \
--disable-opencore-amr \
- --disable-g7221-codec \
- --disable-ilbc-codec \
--disable-libwebrtc \
--disable-opus \
--disable-oss \
--disable-ext-sound \
- --disable-g711-codec \
- --disable-l16-codec \
- --disable-g722-codec \
--disable-libsamplerate \
--disable-sdl \
--disable-openh264 \
@@ -96,4 +91,31 @@ else
LIBPJSIP_CONF_OPTS += --disable-v4l2
endif
+# Codecs can only be disabled. If explicitly enabled, the check is
+# omitted (but successful), and there is no configure trace "Checking
+# if [codec] codec is disabled...no". So we only explicitly disable it
+# and we do not explicitly enable it, so we get the configure log in
+# both cases.
+ifneq ($(BR2_PACKAGE_LIBPJSIP_CODEC_G711),y)
+LIBPJSIP_CONF_OPTS += --disable-g711-codec
+endif
+
+ifneq ($(BR2_PACKAGE_LIBPJSIP_CODEC_G722),y)
+LIBPJSIP_CONF_OPTS += --disable-g722-codec
+endif
+
+# libpjsip can only use a bundled version of libg7221
+ifneq ($(BR2_PACKAGE_LIBPJSIP_CODEC_G7221),y)
+LIBPJSIP_CONF_OPTS += --disable-g7221-codec
+endif
+
+# libpjsip can only use a bundled version of libilbc
+ifneq ($(BR2_PACKAGE_LIBPJSIP_CODEC_ILBC),y)
+LIBPJSIP_CONF_OPTS += --disable-ilbc-codec
+endif
+
+ifneq ($(BR2_PACKAGE_LIBPJSIP_CODEC_L16),y)
+LIBPJSIP_CONF_OPTS += --disable-l16-codec
+endif
+
$(eval $(autotools-package))
--
2.13.6
next prev parent reply other threads:[~2017-11-20 18:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 18:08 [Buildroot] [NEXT v3 1/8] libpjsip: add alsa option Adam Duskett
2017-11-20 18:08 ` [Buildroot] [NEXT v3 2/8] libpjsip: add portaudio option Adam Duskett
2017-11-20 18:09 ` [Buildroot] [NEXT v3 3/8] libpjsip: enable ffmpeg support Adam Duskett
2017-11-20 18:09 ` [Buildroot] [NEXT v3 4/8] libpjsip: enable v4l2 support Adam Duskett
2017-11-20 18:09 ` Adam Duskett [this message]
2017-11-20 18:09 ` [Buildroot] [NEXT v3 6/8] libpjsip: add codecs with dependencies Adam Duskett
2017-11-20 18:09 ` [Buildroot] [NEXT v3 7/8] libpjsip: enable libsamplerate Adam Duskett
2017-11-20 18:09 ` [Buildroot] [NEXT v3 8/8] libpjsip: enable resample Adam Duskett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120180905.5903-5-aduskett@gmail.com \
--to=aduskett@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox