From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 21 Nov 2017 13:56:22 +0100 Subject: [Buildroot] [PATCH v4 1/2] libkrb5: New package In-Reply-To: <1511213549-1878-1-git-send-email-nerv@dawncrow.de> References: <1511213549-1878-1-git-send-email-nerv@dawncrow.de> Message-ID: <20171121135622.033678af@windsurf.lan> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, Thanks for this new iteration. Much better without the configure.ac patch. On Mon, 20 Nov 2017 22:32:28 +0100, Andr? Hentschel wrote: > +LIBKRB5_VERSION = 1.15.2 > +LIBKRB5_SITE = https://web.mit.edu/kerberos/dist/krb5/1.15 > +LIBKRB5_SOURCE = krb5-$(LIBKRB5_VERSION).tar.gz > +LIBKRB5_SUBDIR = src > +LIBKRB5_LICENSE = MIT > +LIBKRB5_LICENSE_FILES = NOTICE > +LIBKRB5_INSTALL_STAGING = YES > +LIBKRB5_AUTORECONF = YES Are you sure you still need to AUTORECONF the package? Now that the configure.ac patch is gone, I don't think this is necessary anymore. > +# Add sane assumptions about cross-compiling Rather than "sane assumptions", a clearer comment would be: "The configure script uses AC_TRY_RUN tests to check for those values, which doesn't work in a cross-compilation scenario. Therefore, we feed the configure script with the correct answer for those tests". Or something along those lines. Note: both issues can be fixed when applying, no need to resend just for that. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com