From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] systemd: set time epoch for reproducible builds
Date: Wed, 22 Nov 2017 22:16:39 +0100 [thread overview]
Message-ID: <20171122221639.40f60340@windsurf.lan> (raw)
In-Reply-To: <20171116170316.19081-1-john@metanate.com>
Hello,
On Thu, 16 Nov 2017 17:03:16 +0000, John Keeping wrote:
> Systemd embeds a timestamp which is used to impose a minimum bound on
> the system time during boot. Normally this comes from stat'ing the NEWS
> file included with the systemd source, but this makes the build
> non-reproducible. Pass in $SOURCE_DATE_EPOCH to use a deterministic
> timestamp when reproducible builds are enabled.
>
> Signed-off-by: John Keeping <john@metanate.com>
> ---
> package/systemd/systemd.mk | 5 +++++
> 1 file changed, 5 insertions(+)
Following the feedback from Peter Korsgaard and myself, and the lack of
additional justification, I've marked this patch as "Rejected" in our
patch tracking system.
John: don't hesitate to get back to us with a more detailed explanation
of the issue if you have not been convinced by Peter's explantion and
mine.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-11-22 21:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 17:03 [Buildroot] [PATCH] systemd: set time epoch for reproducible builds John Keeping
2017-11-17 9:55 ` Thomas Petazzoni
2017-11-17 10:33 ` Peter Korsgaard
2017-11-22 21:16 ` Thomas Petazzoni [this message]
2017-11-23 12:26 ` John Keeping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171122221639.40f60340@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox