From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libupnp18: new package
Date: Thu, 23 Nov 2017 21:43:18 +0100 [thread overview]
Message-ID: <20171123214318.72a8901d@windsurf.lan> (raw)
In-Reply-To: <20171118202440.28645-1-fontaine.fabrice@gmail.com>
Hello,
On Sat, 18 Nov 2017 21:24:40 +0100, Fabrice Fontaine wrote:
> Branch 1.8.x of libupnp is not compatible with branch 1.6.x so add a
> dedicated package and make it depends on !BR2_PACKAGE_LIBUPNP as
> suggested by Thomas Petazzoni and Arnout Vandecappelle during review
> of "libupnp: add 1.8.3 version" patch.
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Thanks, I've applied to next, with one minor tweak.
> diff --git a/package/libupnp18/Config.in b/package/libupnp18/Config.in
> new file mode 100644
> index 000000000..80ac59542
> --- /dev/null
> +++ b/package/libupnp18/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_LIBUPNP18
> + bool "libupnp18"
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> + depends on !BR2_PACKAGE_LIBUPNP
> + help
> + The portable SDK for UPnP(tm) Devices (libupnp) provides
> + developers with an API and open source code for building
> + control points, devices, and bridges that are compliant with
> + Version 1.0 of the Universal Plug and Play Device Architecture
> + Specification
> +
> + http://pupnp.sourceforge.net/
> +
> +comment "libupnp18 needs a toolchain w/ threads"
> + depends on !BR2_TOOLCHAIN_HAS_THREADS
I've added:
depends on !BR2_PACKAGE_LIBUPNP
otherwise the Config.in comment would appear even if libupnp18 is not
selectable.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-11-23 20:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 20:24 [Buildroot] [PATCH 1/1] libupnp18: new package Fabrice Fontaine
2017-11-23 20:43 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123214318.72a8901d@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox